EwanCrawford added a comment.
Thanks for fixing this Adrian
Repository:
rL LLVM
http://reviews.llvm.org/D15092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
In http://reviews.llvm.org/D15067#298902, @Eugene.Zelenko wrote:
> But it's necessary to pass path from CMake command line argument to
> find_program after PATHS. Another problem if default OS location (if Clang
> installed and of old version) will be returned instead of
ravitheja added a comment.
Hi Jason,
Ok let me explain the scenario here, the application i.e the test function
tries to abort which eventually ends up in a function present in the vdso, on
the way the call flow goes through some functions in libc. Now the backtrace is
done from inside of th
abhishek.aggarwal added a comment.
Hello Greg
Is there anyone else , except the reviewers already included for the patch, I
should put as the reviewer for this patch ?
http://reviews.llvm.org/D15042
___
lldb-commits mailing list
lldb-commits@lists
labath added a subscriber: labath.
labath accepted this revision.
labath added a reviewer: labath.
labath added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D15042
___
lldb-commits mailing list
lldb
Author: labath
Date: Tue Dec 1 05:28:47 2015
New Revision: 254403
URL: http://llvm.org/viewvc/llvm-project?rev=254403&view=rev
Log:
Fix race during process interruption
Summary:
The following situation was occuring in TestAttachResume:
- we did a "continue" from a breakpoint (which involves a pr
This revision was automatically updated to reflect the committed changes.
labath marked 3 inline comments as done.
Closed by commit rL254403: Fix race during process interruption (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D14989?vs=41215&id=41482#toc
Repository:
r
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
Looks good, and as it only effects Linux you can commit it just based on the
review from Pavel
http://reviews.llvm.org/D15042
___
lldb-commi
mohit.bhakkad created this revision.
mohit.bhakkad added a reviewer: clayborg.
mohit.bhakkad added subscribers: jaydeep, bhushan, nitesh.jain, sagar,
lldb-commits.
mohit.bhakkad set the repository for this revision to rL LLVM.
rL249837 doesn't solves all the issues with MIPS false positives, some
abhishek.aggarwal updated this revision to Diff 41489.
abhishek.aggarwal added a comment.
Added Loggings
An indication through logs in case ptrace API fails
to read FXSAVE/XSAVE area.
http://reviews.llvm.org/D15042
Files:
packages/Python/lldbsuite/test/functionalities/return-value/TestRetur
abhishek.aggarwal added a comment.
Hi Pavel and Tamas
I enabled logs in case ptrace API fails to read FXSAVE/XSAVE area. This will
serve as an indicator to find the reason of failure if register read fails.
http://reviews.llvm.org/D15042
___
lldb-
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 41490.
tberghammer added a comment.
Herald added a subscriber: emaste.
Address review comments
http://reviews.llvm.org/D11465
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
pa
tberghammer updated this revision to Diff 41491.
http://reviews.llvm.org/D11465
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py
source/API/SBProcess.cpp
source/Commands/CommandObjectProcess.
tberghammer added inline comments.
Comment at: test/functionalities/load_unload/TestLoadUnload.py:201-204
@@ -205,7 +200,6 @@
-if lldb.remote_platform:
-dylibName = os.path.join(shlib_dir, 'libloadunload_a.so')
-elif self.platformIsDarwin():
+
tberghammer added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:853-854
@@ +852,4 @@
+{
+if (log)
+log->Printf("NativeRegisterContextLinux_x86_64::%s ptrace
APIs failed to read XSAV
abhishek.aggarwal added a comment.
Comments Inlined.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:853-854
@@ +852,4 @@
+{
+if (log)
+log->Printf("NativeRegisterContextLinux_x86_64::%s ptrace
APIs
EwanCrawford created this revision.
EwanCrawford added a reviewer: spyffe.
EwanCrawford added a subscriber: lldb-commits.
EwanCrawford set the repository for this revision to rL LLVM.
I came across a bug for calling functions using expression evaluation, where
the function name also matches a sym
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D11465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: labath
Date: Tue Dec 1 11:59:56 2015
New Revision: 254430
URL: http://llvm.org/viewvc/llvm-project?rev=254430&view=rev
Log:
Revert "Fix race during process interruption"
The android buildbot gets quite flaky after this change. I'm reverting it while
I investigate.
Modified:
lldb/tr
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#299220, @labath wrote:
> In http://reviews.llvm.org/D15067#298902, @Eugene.Zelenko wrote:
>
> > But it's necessary to pass path from CMake command line argument to
> > find_program after PATHS. Another problem if default OS locati
On 12/01/2015 02:05 AM, David Blaikie wrote:
On Mon, Nov 30, 2015 at 5:00 PM, Galina Kistanova mailto:gkistan...@gmail.com>> wrote:
Hi David,
Thank you for the useful suggestions, I will work on these.
>I guess the entries with no entry in the failed column have zero failures?
Author: gclayton
Date: Tue Dec 1 18:43:32 2015
New Revision: 254476
URL: http://llvm.org/viewvc/llvm-project?rev=254476&view=rev
Log:
Added support for -gmodule debugging when debug info is left in the .o files on
Darwin.
This is done by finding the types that are forward declarations that come
Hi Ravitheja, thanks for the logging output. It does look like the assembly
profiling is failing for some reason, and with your patch we fall back to using
the eh_frame instructions and it succeeds. I'll look at the patch closely
tomorrow (I meant to do it tonight but I'm running out of time b
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
Hi Ravitheja, thanks for the logging output. It does look like the assembly
profiling is failing for some reason, and with your patch we fall back to using
the eh_frame instructions and it succeeds. I'll look at the p
jasonmolenda added a comment.
Just to be clear - the change your proposing may be a good improvement for
falling back to another unwind plan when the initial unwind plan fails. But
I'm curious why the initial unwind plan (assembly) failed here to begin with.
I think lldb should have profiled
25 matches
Mail list logo
