[Lldb-commits] [lldb] r254194 - Re-add an xfail removed by r254163

2015-11-27 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Nov 27 04:50:33 2015 New Revision: 254194 URL: http://llvm.org/viewvc/llvm-project?rev=254194&view=rev Log: Re-add an xfail removed by r254163 The test is flakey but it fails too often with gcc 4.9.2 on x86_64 to be marked only as expected flakey. Modified: lld

Re: [Lldb-commits] [PATCH] D14952: Create new "platform process connect" command

2015-11-27 Thread Pavel Labath via lldb-commits
labath added a comment. Thank you for writing the test. I have just a couple of more comments and them I'm done... :) Please wait for @clayborg to sign off on this as well. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/platform-process-connect/TestPlatformProce

[Lldb-commits] [lldb] r254200 - [LLGS] Don't forward I/O when process is stopped

2015-11-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Nov 27 07:33:29 2015 New Revision: 254200 URL: http://llvm.org/viewvc/llvm-project?rev=254200&view=rev Log: [LLGS] Don't forward I/O when process is stopped Summary: This makes sure we do not attempt to send output over the gdb-remote protocol when the client is not expe

Re: [Lldb-commits] [PATCH] D15019: [LLGS] Don't forward I/O when process is stopped

2015-11-27 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL254200: [LLGS] Don't forward I/O when process is stopped (authored by labath). Changed prior to commit: http://reviews.llvm.org/D15019?vs=41241&id=41298#toc Rep

Re: [Lldb-commits] [PATCH] D15042: PTRACE ABI to read FXSAVE area for 32-bit inferior

2015-11-27 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:849-850 @@ -844,2 +848,4 @@ m_fpr_type = eFPRTypeFXSAVE; +assert (const_cast(this)->ReadFPR().Success() && +"ptrace APIs

Re: [Lldb-commits] [PATCH] D14952: Create new "platform process connect" command

2015-11-27 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 41312. tberghammer marked 4 inline comments as done. tberghammer added a comment. Improve the test based on the comments http://reviews.llvm.org/D14952 Files: include/lldb/Target/Platform.h packages/Python/lldbsuite/test/lldbtest.py packages/Pytho

Re: [Lldb-commits] [PATCH] D14952: Create new "platform process connect" command

2015-11-27 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py:13 @@ +12,3 @@ +def test_platform_process_connect(self): +if not lldb.remote_platform: +self.skipTest("On