omjavaid added a comment.
Some minor typos inline comments.
I havnt applied nd tested this patch. Are you able to read these registers, i
guess you need to generate neon or vfp code to test all registers properly.
There no arm register test to my knowledge currently in testsuite we can put
thi
labath updated this revision to Diff 41215.
labath added a comment.
Fix typo
http://reviews.llvm.org/D14989
Files:
include/lldb/Target/Process.h
packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
packages/Python/lldbsuite/test/functionalities/attach_resume/
tberghammer created this revision.
tberghammer added reviewers: omjavaid, labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Make some of the tests in TestRegisters.py arm compatible
http://reviews.llvm.org/D15010
Files:
packages/Python/lldbsuit
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great. Thank you for taking the time to do this.
http://reviews.llvm.org/D15010
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
tberghammer added a comment.
I made some of the tests in TestRegisters.py arm compatible (see
http://reviews.llvm.org/D15010) and we also test register read/write in some
extent with the gdb remote protocol tests (they caught several issues while I
was doing this patch)
Comme
tberghammer updated this revision to Diff 41228.
http://reviews.llvm.org/D14985
Files:
source/Core/Scalar.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
source/Plugins/Process/Utility/RegisterContextFreeBSD_arm.cpp
source/Plugins/Process/Utility/RegisterContextLinux_a
sagar updated this revision to Diff 41232.
sagar added a comment.
Addressed review comments
Repository:
rL LLVM
http://reviews.llvm.org/D14633
Files:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
Index: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cp
labath created this revision.
labath added reviewers: tberghammer, ovyalov.
labath added a subscriber: lldb-commits.
This makes sure we do not attempt to send output over the gdb-remote protocol
when the client is
not expecting it (i.e., after sending the stop-reply packet). Normally, this
shoul
omjavaid accepted this revision.
omjavaid added a comment.
LGTM
http://reviews.llvm.org/D14985
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tberghammer
Date: Thu Nov 26 09:02:35 2015
New Revision: 254153
URL: http://llvm.org/viewvc/llvm-project?rev=254153&view=rev
Log:
Make some of the tests in TestRegisters.py arm compatible
Differential revision: http://reviews.llvm.org/D15010
Modified:
lldb/trunk/packages/Python/lldb
Author: tberghammer
Date: Thu Nov 26 09:02:31 2015
New Revision: 254152
URL: http://llvm.org/viewvc/llvm-project?rev=254152&view=rev
Log:
Add 64/128 bit arm neon register definitions on linux
Differential revision: http://reviews.llvm.org/D14985
Modified:
lldb/trunk/source/Core/Scalar.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254152: Add 64/128 bit arm neon register definitions on
linux (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D14985?vs=41228&id=41247#toc
Repository:
rL LLVM
http://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254153: Make some of the tests in TestRegisters.py arm
compatible (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15010?vs=41225&id=41248#toc
Repository:
rL LLVM
http://
Author: tberghammer
Date: Thu Nov 26 10:11:57 2015
New Revision: 254163
URL: http://llvm.org/viewvc/llvm-project?rev=254163&view=rev
Log:
Remove some xfail-s fixed by r253026
These tests were fixed by r253026 but they was failing on the linux
build bot because of a system setup problem. Remove xf
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1014
@@ +1013,3 @@
+
+Error error;
+m_stdio_handle_up = m_mainloop.R
Author: tberghammer
Date: Thu Nov 26 11:43:24 2015
New Revision: 254166
URL: http://llvm.org/viewvc/llvm-project?rev=254166&view=rev
Log:
Fix TestRegisters.py on arm
Previously it tried to write a bit in the FPSCR register marked as
do not modify what failed on some device.
Modified:
lldb/t
tberghammer updated this revision to Diff 41266.
tberghammer added a comment.
Add test
http://reviews.llvm.org/D14952
Files:
include/lldb/Target/Platform.h
packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
packages/Python/lldbsuite/test/tools/lldb-server/platform-pro
tberghammer marked an inline comment as done.
Comment at: source/Commands/CommandObjectPlatform.cpp:2040-2041
@@ -1968,13 +2039,4 @@
"platform process",
"A set of commands to query, launch and attach
to platform pr
18 matches
Mail list logo