Re: [Lldb-commits] [PATCH] D13942: Make SymbolFileDWARF::GetCachedSectionData thread safe

labath accepted this revision. labath added a comment. The new version of the patch looks much cleaner than the old one. Thanks. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:641 @@ -669,3 +640,3 @@ { -if (m_flags.IsClear (got_flag)) +std::call_once(da

[Lldb-commits] [lldb] r251003 - [RenderScript] Support for mips64 runtime hook

Author: ewancrawford Date: Thu Oct 22 04:01:05 2015 New Revision: 251003 URL: http://llvm.org/viewvc/llvm-project?rev=251003&view=rev Log: [RenderScript] Support for mips64 runtime hook Previously we could not hook the RS runtime on mips64 architectures. Patch implements ABI specific code for in

Re: [Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

labath added a subscriber: labath. Comment at: test/make/Makefile.rules:304 @@ -303,3 +303,3 @@ else - CXXFLAGS += -stdlib=libc++ + CXXFLAGS += -stdlib=libc++ -DLLDB_USING_LIBCPP LDFLAGS += -stdlib

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D13970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn added a comment. One resolution would be to check for the cmake version and conditionally enable the new code, but that's beyond my capabilities - anyone know how? If not, can we please revert this commit? Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 __

Re: [Lldb-commits] [PATCH] D13948: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL251004: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13948?vs=38020&id=38103#toc Repository: rL

[Lldb-commits] [lldb] r251004 - [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets

Author: labath Date: Thu Oct 22 04:34:40 2015 New Revision: 251004 URL: http://llvm.org/viewvc/llvm-project?rev=251004&view=rev Log: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets Summary: This short-circuits the GetObjCVersion function to avoid iterating through ta

Re: [Lldb-commits] [PATCH] D13947: [lldb-mi] Fix expansion of anonymous structures and unions

abidh accepted this revision. abidh added a comment. LGTM. Thanks for doing it. For this case, the output of the lldb-mi looks more sensible then gdb. http://reviews.llvm.org/D13947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

Re: [Lldb-commits] [PATCH] D13602: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks reasonable Repository: rL LLVM http://reviews.llvm.org/D13602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [lldb] r251006 - Fix some race condition in ConstString around Mangled name handling

Author: tberghammer Date: Thu Oct 22 06:14:31 2015 New Revision: 251006 URL: http://llvm.org/viewvc/llvm-project?rev=251006&view=rev Log: Fix some race condition in ConstString around Mangled name handling Differential revision: http://reviews.llvm.org/D13941 Modified: lldb/trunk/source/Core

Re: [Lldb-commits] [PATCH] D13942: Make SymbolFileDWARF::GetCachedSectionData thread safe

This revision was automatically updated to reflect the committed changes. Closed by commit rL251007: Make SymbolFileDWARF::GetCachedSectionData thread safe (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D13942?vs=38019&id=38109#toc Repository: rL LLVM http://rev

[Lldb-commits] [lldb] r251007 - Make SymbolFileDWARF::GetCachedSectionData thread safe

Author: tberghammer Date: Thu Oct 22 06:14:37 2015 New Revision: 251007 URL: http://llvm.org/viewvc/llvm-project?rev=251007&view=rev Log: Make SymbolFileDWARF::GetCachedSectionData thread safe Differential revision: http://reviews.llvm.org/D13942 Modified: lldb/trunk/source/Plugins/SymbolFil

Re: [Lldb-commits] [PATCH] D13941: Fix some race condition in ConstString around Mangled name handling

This revision was automatically updated to reflect the committed changes. tberghammer marked 5 inline comments as done. Closed by commit rL251006: Fix some race condition in ConstString around Mangled name handling (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D139

[Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

tberghammer created this revision. tberghammer added reviewers: clayborg, brucem. tberghammer added a subscriber: lldb-commits. Disable the strict-aliasing warnings produced by gcc GCC produce a lot of strict-aliasing warning for the LLDB codebase what makes reading the compile output very diffic

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

enlight added a comment. It seems like it should be possible to conditionally enable this using CMAKE_VERSION . However that just means anyone who's silly enough to use an older CMake version may run into the

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

tberghammer updated this revision to Diff 38118. tberghammer added a comment. We already used some thread local storage in the same file to store the current Timer stack so I decided to move the depth to the same storage object (it is using the Host::ThreadLocalStorage* methods). Originally I d

Re: [Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

labath added a subscriber: labath. labath added a comment. Could you also file a bug about that? most of these are real problems I think, and we should not forget them... http://reviews.llvm.org/D13981 ___ lldb-commits mailing list lldb-commits@lis

Re: [Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

brucem added a comment. It might be worthwhile to have a "janitor" where we can not enable things like this so that it is more clear that this is something we'd like to clean up over time. It would be pretty easy to just have a `if (NOT LLDB_JANITOR_MODE AND CXX_SUPPORTS_NO_STRICT_ALIASING)` c

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

labath added a subscriber: labath. labath added a comment. I don't think we should bump the version over a trivial issue like this. cmake 2.8 is still the default on alot of systems. Wouldn't a well placed quote work also? Like, `FOO="${BAR}" codesign --force --end` Or just putting the command i

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

brucem added a comment. +1 to what @labath said. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

sivachandra added a subscriber: sivachandra. sivachandra added a comment. If this fixes the windows build, can you please commit it ASAP? Repository: rL LLVM http://reviews.llvm.org/D13968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

tberghammer removed rL LLVM as the repository for this revision. tberghammer updated this revision to Diff 38128. tberghammer added a comment. I tried out the implementation you suggests and made some measurements. The difference between the 2 implementation when attaching to LLDB is negligible

[Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

labath created this revision. labath added reviewers: granata.enrico, tfiala. labath added a subscriber: lldb-commits. The list of loaded modules which skip_if_library_missing is depending on is not available on linux until after we run the target. This causes the tests to be wrongfully skipped.

Re: [Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Good catch! http://reviews.llvm.org/D13985 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

tfiala added a comment. (I don't think you need to wait for Enrico, btw.) http://reviews.llvm.org/D13985 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

tfiala added a comment. Yeah, if you can make that happen, that sounds good to me. This is a "if you have libc++, please build with it, otherwise skip this test"-kinda test... :-) http://reviews.llvm.org/D13964 ___ lldb-commits mailing list lldb-c

Re: [Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

tfiala closed this revision. tfiala added a comment. Forgot to mark this as closed: Closed by commit: r250965 | tfiala | 2015-10-21 17:23:38 -0700 (Wed, 21 Oct 2015) | 4 lines Fix libstdc++ data formatters on Ubunt

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

clayborg accepted this revision. clayborg added a comment. Looks good. At some point we should add these to the PluginMananger and have new instances found by having them register URL prefixes which match up with CreateInstance methods that are given the URL. http://reviews.llvm.org/D13970

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

I would have done this last night but I didn't have a machine handy. I'll test it out now and commit if it fixes. And yea, in the future please just commit fixes. On Thu, Oct 22, 2015 at 6:04 AM Siva Chandra wrote: > sivachandra added a subscriber: sivachandra. > sivachandra added a comment. >

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

zturner added a subscriber: zturner. zturner added a comment. I would have done this last night but I didn't have a machine handy. I'll test it out now and commit if it fixes. And yea, in the future please just commit fixes. Repository: rL LLVM http://reviews.llvm.org/D13968

Re: [Lldb-commits] [PATCH] D13602: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

clayborg accepted this revision. clayborg added a comment. Looks good. I would venture to say just checkin any clang tidy things that aren't changing code functionality without need for review. Repository: rL LLVM http://reviews.llvm.org/D13602

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg added a comment. I would venture to say we should optimize for C++ since those libraries tend to be larger, but I will leave the decision to you. http://reviews.llvm.org/D13662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] r251031 - Attempt to fix MSVC builds after rL250966.

Author: eugenezelenko Date: Thu Oct 22 12:01:20 2015 New Revision: 251031 URL: http://llvm.org/viewvc/llvm-project?rev=251031&view=rev Log: Attempt to fix MSVC builds after rL250966. Differential Revision: http://reviews.llvm.org/D13968 Modified: lldb/trunk/source/Plugins/LanguageRuntime/Ob

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

This revision was automatically updated to reflect the committed changes. Closed by commit rL251031: Attempt to fix MSVC builds after rL250966. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D13968?vs=38070&id=38143#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

ovyalov added a comment. In http://reviews.llvm.org/D13970#273217, @clayborg wrote: > Looks good. At some point we should add these to the PluginMananger and have > new instances found by having them register URL prefixes which match up with > CreateInstance methods that are given the URL. Th

[Lldb-commits] [lldb] r251034 - Add support for abstract domain sockets.

Author: ovyalov Date: Thu Oct 22 12:50:33 2015 New Revision: 251034 URL: http://llvm.org/viewvc/llvm-project?rev=251034&view=rev Log: Add support for abstract domain sockets. http://reviews.llvm.org/D13970 Added: lldb/trunk/include/lldb/Host/linux/AbstractSocket.h lldb/trunk/source/Host

[Lldb-commits] [lldb] r251044 - Set device_id to host value only in case of adb protocol.

Author: ovyalov Date: Thu Oct 22 14:17:32 2015 New Revision: 251044 URL: http://llvm.org/viewvc/llvm-project?rev=251044&view=rev Log: Set device_id to host value only in case of adb protocol. Modified: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp lldb/trunk/source/Plugi

[Lldb-commits] [lldb] r251047 - Remove special case logic for finding 3rd party libs

Author: zturner Date: Thu Oct 22 14:55:18 2015 New Revision: 251047 URL: http://llvm.org/viewvc/llvm-project?rev=251047&view=rev Log: Remove special case logic for finding 3rd party libs Modified: lldb/trunk/lldb_shared_base.py lldb/trunk/test/dotest.py Modified: lldb/trunk/lldb_shared_b

[Lldb-commits] [lldb] r251054 - Fix Clang-tidy modernize-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

Author: eugenezelenko Date: Thu Oct 22 14:59:21 2015 New Revision: 251054 URL: http://llvm.org/viewvc/llvm-project?rev=251054&view=rev Log: Fix Clang-tidy modernize-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes. Differential Revision: http://reviews.

Re: [Lldb-commits] [PATCH] D13602: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL251054: Fix Clang-tidy modernize-use-override warnings in some files in… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D13602?vs=36981&id=38163#toc Repository: rL LLVM

[Lldb-commits] [lldb] r251060 - Python 3 porting - Wrap returns from map() in list()

Author: zturner Date: Thu Oct 22 15:39:59 2015 New Revision: 251060 URL: http://llvm.org/viewvc/llvm-project?rev=251060&view=rev Log: Python 3 porting - Wrap returns from map() in list() Under Python 2 this has no effect, since map() returns a list. In Python 3 map() returns an iterable, so wrapp

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn added a comment. Please review http://reviews.llvm.org/D13995 for a proposed fix. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] r251066 - Fix Clang-tidy modernize-use-override warnings in include/lldb/Disassembler and OperatingSystem; other minor fixes.

Author: eugenezelenko Date: Thu Oct 22 16:24:37 2015 New Revision: 251066 URL: http://llvm.org/viewvc/llvm-project?rev=251066&view=rev Log: Fix Clang-tidy modernize-use-override warnings in include/lldb/Disassembler and OperatingSystem; other minor fixes. Second attempt which should work for MSV

[Lldb-commits] [PATCH] D13995: [cmake] Fix cmake build on OSX after r250335 for older versions of cmake

dawn created this revision. dawn added reviewers: brucem, sas, krytarowski, enlight, labath. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. Older versions of cmake don't support the -E env option which was added in r250335, causing the build to fail w

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

clayborg added a comment. In http://reviews.llvm.org/D13970#273267, @ovyalov wrote: > In http://reviews.llvm.org/D13970#273217, @clayborg wrote: > > > Looks good. At some point we should add these to the PluginMananger and > > have new instances found by having them register URL prefixes which m

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

sas added a comment. Adding quotes doesn't work. I think the patch that @dawn linked is good enough even though the issue is still not fixed on older cmake versions. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-

Re: [Lldb-commits] [PATCH] D13995: [cmake] Fix cmake build on OSX after r250335 for older versions of cmake

sas accepted this revision. sas added a comment. This revision is now accepted and ready to land. Sorry for introducing this bug. I think this is good. Repository: rL LLVM http://reviews.llvm.org/D13995 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] r251073 - [cmake] Fix cmake build on OSX after r250335 for older versions of cmake

Author: dperchik Date: Thu Oct 22 17:48:52 2015 New Revision: 251073 URL: http://llvm.org/viewvc/llvm-project?rev=251073&view=rev Log: [cmake] Fix cmake build on OSX after r250335 for older versions of cmake Reviewed by: sas Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D13995: [cmake] Fix cmake build on OSX after r250335 for older versions of cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rL251073: [cmake] Fix cmake build on OSX after r250335 for older versions of cmake (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D13995?vs=38176&id=38185#toc Repository: rL L

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn accepted this commit. dawn added a comment. Breakage with older cmake versions fixed in svn r251073. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

[Lldb-commits] [lldb] r251080 - Summary provider for char.

Author: dperchik Date: Thu Oct 22 19:02:56 2015 New Revision: 251080 URL: http://llvm.org/viewvc/llvm-project?rev=251080&view=rev Log: Summary provider for char. This patch enables type summary for 'char' type. Given: char c = 'h'; Before this patch, c evaluates as: (char) $0 = 'h' After

Re: [Lldb-commits] [PATCH] D13657: [lldb] char summary provider

This revision was automatically updated to reflect the committed changes. Closed by commit rL251080: Summary provider for char. (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D13657?vs=37487&id=38187#toc Repository: rL LLVM http://reviews.llvm.org/D13657 Files: l

[Lldb-commits] [lldb] r251082 - [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

Author: dperchik Date: Thu Oct 22 19:23:53 2015 New Revision: 251082 URL: http://llvm.org/viewvc/llvm-project?rev=251082&view=rev Log: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases) Previously, lldb did not use type summaries for simple types with no ch

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

This revision was automatically updated to reflect the committed changes. Closed by commit rL251082: [lldb-mi] display summary for simple types + refactor (use lldb formatting… (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D13799?vs=37888&id=38188#toc Repository: r

[Lldb-commits] [lldb] r251083 - Fixed a typo in r251080.

Author: spyffe Date: Thu Oct 22 19:37:54 2015 New Revision: 251083 URL: http://llvm.org/viewvc/llvm-project?rev=251083&view=rev Log: Fixed a typo in r251080. Modified: lldb/trunk/source/API/SBTypeSummary.cpp Modified: lldb/trunk/source/API/SBTypeSummary.cpp URL: http://llvm.org/viewvc/llvm-

Re: [Lldb-commits] [PATCH] D13657: [lldb] char summary provider

This patch failed to compile. I fixed it with r251083. Sean > On Oct 22, 2015, at 5:05 PM, Phabricator via lldb-commits > wrote: > > +BStream stream; ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

Re: [Lldb-commits] [PATCH] D13657: [lldb] char summary provider

spyffe added a subscriber: spyffe. spyffe added a comment. This patch failed to compile. I fixed it with r251083. Sean Repository: rL LLVM http://reviews.llvm.org/D13657 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [lldb] r251084 - Log information about sections that didn't make it into the target's memory.

Author: spyffe Date: Thu Oct 22 19:39:09 2015 New Revision: 251084 URL: http://llvm.org/viewvc/llvm-project?rev=251084&view=rev Log: Log information about sections that didn't make it into the target's memory. Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp Modified: lldb/trunk/so

[Lldb-commits] [lldb] r251086 - Fix one more place where we were using the old

Author: jmolenda Date: Thu Oct 22 19:59:31 2015 New Revision: 251086 URL: http://llvm.org/viewvc/llvm-project?rev=251086&view=rev Log: Fix one more place where we were using the old name of the xpc service. Modified: lldb/trunk/source/Host/macosx/Host.mm Modified: lldb/trunk/source/Host/ma

[Lldb-commits] [lldb] r251088 - Add arm64 FreeBSD ProcessMonitor register context

Author: emaste Date: Thu Oct 22 20:10:42 2015 New Revision: 251088 URL: http://llvm.org/viewvc/llvm-project?rev=251088&view=rev Log: Add arm64 FreeBSD ProcessMonitor register context Modified: lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp Modified: lldb/trunk/source/Plugins/Pro

[Lldb-commits] [lldb] r251092 - Remove some tabs that snuck into debugserver-entitlements.plist, etc.

Author: jmolenda Date: Thu Oct 22 21:54:21 2015 New Revision: 251092 URL: http://llvm.org/viewvc/llvm-project?rev=251092&view=rev Log: Remove some tabs that snuck into debugserver-entitlements.plist, etc. Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp lldb/trunk/tools/debugse