labath added a comment.
sounds reasonable
http://reviews.llvm.org/D13667
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Wed Oct 14 03:57:55 2015
New Revision: 250280
URL: http://llvm.org/viewvc/llvm-project?rev=250280&view=rev
Log:
Mark TestBatchMode as flaky on linux
Modified:
lldb/trunk/test/driver/batch_mode/TestBatchMode.py
Modified: lldb/trunk/test/driver/batch_mode/TestBatchMode.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250281: RenderScript command for printing allocation
contents (authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D13699?vs=37251&id=37324#toc
Repository:
rL LLVM
http://rev
Author: ewancrawford
Date: Wed Oct 14 04:02:20 2015
New Revision: 250281
URL: http://llvm.org/viewvc/llvm-project?rev=250281&view=rev
Log:
RenderScript command for printing allocation contents
This patch adds the command 'language renderscript allocation dump ' for
printing the contents of a RS
Author: labath
Date: Wed Oct 14 04:18:23 2015
New Revision: 250282
URL: http://llvm.org/viewvc/llvm-project?rev=250282&view=rev
Log:
Fix compiler warnings in ScriptInterpreterPython
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
Modified:
lldb/trun
abidh created this revision.
abidh added reviewers: zturner, clayborg.
abidh added a subscriber: lldb-commits.
I see a lot of following warnings in LLDBWrapPython.cpp while building with gcc
4.9 on Linux.
"warning: cast from type ‘const char*’ to type ‘char*’ casts away qualifiers
[-Wcast-qual]"
labath added a subscriber: labath.
labath added a comment.
Hi Ewan,
this commit introduces a new warning:
lldb/source/Commands/CommandObjectMemory.cpp:1502:21: warning: enumeration
value 'eFormatVectorOfFloat16' not handled in switch [-Wswitch]
switch (m_format_options.GetFormat
EwanCrawford added a comment.
Hi Pavel,
Thanks for letting me know, I'll look into it now.
Repository:
rL LLVM
http://reviews.llvm.org/D13699
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
krytarowski added a comment.
There is already preliminary NetBSD support merged with trunk, I need this
commit (or altered version of it) to build lldb against ncurses on this
platform.
Thank you for your time.
Repository:
rL LLVM
http://reviews.llvm.org/D12994
_
Author: tberghammer
Date: Wed Oct 14 05:29:36 2015
New Revision: 250287
URL: http://llvm.org/viewvc/llvm-project?rev=250287&view=rev
Log:
Fix warning in CommandObjectMemory
Modified:
lldb/trunk/source/Commands/CommandObjectMemory.cpp
Modified: lldb/trunk/source/Commands/CommandObjectMemory.c
Author: tberghammer
Date: Wed Oct 14 05:29:17 2015
New Revision: 250286
URL: http://llvm.org/viewvc/llvm-project?rev=250286&view=rev
Log:
Make use of lldv::Triple::isAndroid
It is a new function added to the llvm::Triple class to simplify the
checking if we are targeting android to clean up the c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250289: Change ConstString to support massive multi-threaded
access (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13652?vs=37258&id=37328#toc
Repository:
rL LLVM
http:
Author: tberghammer
Date: Wed Oct 14 05:38:22 2015
New Revision: 250289
URL: http://llvm.org/viewvc/llvm-project?rev=250289&view=rev
Log:
Change ConstString to support massive multi-threaded access
Previously ConstString had a single mutex guarding the global string
pool for each access what beco
Author: labath
Date: Wed Oct 14 06:50:37 2015
New Revision: 250290
URL: http://llvm.org/viewvc/llvm-project?rev=250290&view=rev
Log:
Revert "RenderScript command for printing allocation contents"
This commit breaks TestDataFormatterSmartArray on all buildbots.
Modified:
lldb/trunk/include/ll
labath added a comment.
Hi,
I have reverted this as all the bots were getting red. In the test, variable
was getting printed as `[{},{},{},{},{},{},{}]` instead of
`{78.5},{77.25},{78},{76.125},{76.75},{76.875},{77}`. Please resubmit once the
issue is resolved.
Repository:
rL LLVM
http://
labath updated this revision to Diff 37340.
labath added a comment.
The new functionality gets picked up by the client and automatically used
everywhere, so I'm not
really worried about testing it. A more important issue would be making sure
that the legacy read
packet does not rot as it is now
evgeny777 updated this revision to Diff 37339.
evgeny777 added a comment.
Looks like can be done much easier
http://reviews.llvm.org/D13657
Files:
include/lldb/API/SBTypeSummary.h
source/API/SBTypeSummary.cpp
Index: source/API/SBTypeSummary.cpp
=
labath updated this revision to Diff 37341.
labath added a comment.
Remove files which slipped in...
http://reviews.llvm.org/D13695
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
source/Plu
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D13695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
EwanCrawford added a comment.
No bother, thanks for reverting
Repository:
rL LLVM
http://reviews.llvm.org/D13699
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Wed Oct 14 07:59:37 2015
New Revision: 250295
URL: http://llvm.org/viewvc/llvm-project?rev=250295&view=rev
Log:
lldb-server: add support for binary memory reads
Summary:
This commit adds support for binary memory reads ($x) to lldb-server. It also
removes the "0x"
prefix fro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250295: lldb-server: add support for binary memory reads
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13695?vs=37341&id=37342#toc
Repository:
rL LLVM
http://reviews.llvm.o
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg, vharron, zturner.
tberghammer added a subscriber: lldb-commits.
Herald added a subscriber: iancottrell.
Add a new task pool class to LLDB to make it easy to execute tasks in parallel
Basic design goals:
* Have a ver
tberghammer updated this revision to Diff 37353.
tberghammer added a comment.
Herald added a subscriber: iancottrell.
Use the new ThreadPool class and make the Append+Finalize stage parallel.
http://reviews.llvm.org/D13662
Files:
source/Plugins/SymbolFile/DWARF/NameToDIE.cpp
source/Plugins/
Author: tfiala
Date: Wed Oct 14 09:52:15 2015
New Revision: 250299
URL: http://llvm.org/viewvc/llvm-project?rev=250299&view=rev
Log:
cmake: provide flag that enables 'log enable --stack' to provide useful
file/function info on POSIX systems
Adding the following flag to a cmake line:
-DLLDB_EXPOR
tfiala closed this revision.
tfiala added a comment.
Closed by the following commit:
svn commit
Sendingcmake/modules/AddLLDB.cmake
Sendingcmake/modules/LLDBConfig.cmake
Sendingsource/API/CMakeLists.txt
Transmitting file data ...
Committed revision 250299.
htt
tweakoz added a subscriber: tweakoz.
tweakoz added a comment.
I am hitting this also.
Happens when I want a summary and a synthetic on the same type...
http://reviews.llvm.org/D10624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
Although it may not seem from the number of my comments, I actually quite like
this implementation. However, I think more work needs to be done to make this
future-proof.
- we defin
EwanCrawford created this revision.
EwanCrawford added reviewers: granata.enrico, clayborg, jingham.
EwanCrawford added subscribers: lldb-commits, domipheus, labath.
EwanCrawford set the repository for this revision to rL LLVM.
Previous patch http://reviews.llvm.org/D13699 broke
TestDataFormatter
zturner added a comment.
Can this be done in such a way that everything boils down to a single call to
std::async on platforms that support thread limiting?
Alternatively, why not just put a semaphore inside of the lambda that you run
with std::async to limit the number of threads? This seems
Author: zturner
Date: Wed Oct 14 11:59:44 2015
New Revision: 250304
URL: http://llvm.org/viewvc/llvm-project?rev=250304&view=rev
Log:
Minor cleanup on PythonDataObject constructors.
Added a constructor that takes list_size for `PythonList`.
Made all single-argument constructors explicit.
Re-order
Author: zturner
Date: Wed Oct 14 11:59:32 2015
New Revision: 250303
URL: http://llvm.org/viewvc/llvm-project?rev=250303&view=rev
Log:
Change swig interface files to use PythonDataObjects.
Modified:
lldb/trunk/scripts/Python/python-extensions.swig
lldb/trunk/scripts/Python/python-typemaps.
tberghammer added a comment.
We can change this class to use std::async on Windows and an std::thread based
implementation on Linux with the same interface (other OS-es should be decided)
but I would prefer to use just 1 logic as it is easier to maintain.
Limiting the number of threads with add
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Missing the TaskPool.h and TaskPool.cpp files?
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-commits@lists.llvm
zturner added a comment.
Ok, it seems reasonable to just use std::async on platforms that this is ok on,
and not use it on platforms which it's not ok on. I think it should be enabled
on Windows, but I'll leave it up to you to decide whether it's a whitelist or a
blacklist.
http://reviews.ll
granata.enrico added a comment.
Admittedly way simpler than my original idea. +1
Having the RTTI support so that these SBTypeSummary objects can actually be
used for anything other than mere creation would be nice.
However, I can fill that gap myself later.
Comment at: source/
Author: zturner
Date: Wed Oct 14 12:51:29 2015
New Revision: 250306
URL: http://llvm.org/viewvc/llvm-project?rev=250306&view=rev
Log:
Fix Python initialization for Python 3.
Python 3 reverses the order in which you must call Py_InitializeEx
and PyEval_InitThreads. Since that log is in itself alr
granata.enrico added inline comments.
Comment at: source/API/SBTypeSummary.cpp:155
@@ +154,3 @@
+ new CXXFunctionSummaryFormat(options,
+ [cb] (ValueObject& valobj, Stream& stm, const
TypeSummaryOptions& opt) -> bool {
+
granata.enrico added a subscriber: granata.enrico.
granata.enrico added a comment.
Is there any reason why we need a special command here?
Are these allocations not bound to any user-visible variable, such that one
could get the same result by using our existing data inspection commands
(expres
tberghammer added a comment.
Please see http://reviews.llvm.org/D13727
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
I agree with labath's comments and see if we can move TaskPoolImpl into the
.cpp file.
Comment at: include/lldb/Utility/TaskPool.h:39-66
@@ +38,30 @@
+
+class TaskPoolImpl
+{
+public:
+Ta
clayborg added a comment.
Any std::async adoption will need to be able to deliver tasks as they complete
via "TaskRunner::WaitForNextCompletedTask()".
We had a previous example where 1000 items could be pushed onto a std::vector
of tasks and then the code was doing:
for (i=0; ihttp://reviews
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Just saw that patch, so this looks good then pending the other patch.
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-commi
clayborg added a comment.
BTW: if we can modify clang to produce the Apple accelerator tables, we won't
need to do any of this indexing which will really speed up debugging! We only
produce the Apple accelerator tables on Darwin, but we could on other systems.
There is also a new version of the
zturner added a comment.
I thought about this some more and I'm fine with going with a single
implementation and not using std async. It would be nice to take advantage of
any deep optimizations std::async provides over a hand-rolled solution, but at
the same time there's a cost to adding comp
On 14 October 2015 at 13:51, Zachary Turner via lldb-commits
wrote:
> Author: zturner
> Date: Wed Oct 14 12:51:29 2015
> New Revision: 250306
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250306&view=rev
> Log:
> Fix Python initialization for Python 3.
This introduced a new warning for me:
..
evgeny777 added a comment.
One question: CreateWithCallback and CreateWithSummaryString do not require
Python support and can be used with LLDB_DISABLE_PYTHON. May be it makes sense
to remove conditional compilation, like it is done here:
http://reviews.llvm.org/D13577
Commen
zturner added a comment.
The only real suggestion / question I have is a design one.
By using this implementation we can't take advantage of the system thread pool.
That was the point of using std async in the first place, but we found that it
doesn't always limit the number of threads. Maybe
granata.enrico added inline comments.
Comment at: source/API/SBTypeSummary.cpp:155
@@ +154,3 @@
+ new CXXFunctionSummaryFormat(options,
+ [cb] (ValueObject& valobj, Stream& stm, const
TypeSummaryOptions& opt) -> bool {
+
evgeny777 added inline comments.
Comment at: source/API/SBTypeSummary.cpp:157
@@ +156,3 @@
+SBStream stream;
+if (!cb(valobj.GetSP(), &opt, stream))
+return false;
granata.enri
Thanks for the heads up. I have some more patches coming in soon, since
this is just a warning and not a blocker I'll fix it in one of these
followup patches.
On Wed, Oct 14, 2015 at 11:38 AM Ed Maste wrote:
> On 14 October 2015 at 13:51, Zachary Turner via lldb-commits
> wrote:
> > Author: zt
clayborg added a comment.
Zach: If these are implementation details, lets get this in first and then
worry about optimizations later.
http://reviews.llvm.org/D13727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
zturner added a comment.
Well, it's not just an optimization. Threading code is hard to reason about,
and the more complicated an implementation the more likely it is to have race
conditions or other problems. So any opportunity to reduce the amount of
manual thread management is a win in tha
Author: sas
Date: Wed Oct 14 15:39:41 2015
New Revision: 250322
URL: http://llvm.org/viewvc/llvm-project?rev=250322&view=rev
Log:
Avoid a -Wreorder warning in ScriptInterpreterPython.cpp.
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
Modified:
lld
granata.enrico added a comment.
So, if you do the explicit constructor change and handle the case of a nullptr
Callback I think it should be good to go. Looking forward to it!
Comment at: source/API/SBTypeSummary.cpp:157
@@ +156,3 @@
+SBStream stream
Thanks, I had a CL coming to fix this but you beat me to it.
On Wed, Oct 14, 2015 at 1:41 PM Stephane Sezer via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: sas
> Date: Wed Oct 14 15:39:41 2015
> New Revision: 250322
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250322&view=rev
sas created this revision.
sas added reviewers: clayborg, dawn, brucem, tfiala.
sas added a subscriber: lldb-commits.
Looks like having a space in the Xcode path triggers this bug. We need
to use cmake -E env FOO=bar [COMMAND] to set the environment instead.
I am using cmake 3.3.1 and ninja 1.6.0
Author: zturner
Date: Wed Oct 14 16:06:13 2015
New Revision: 250327
URL: http://llvm.org/viewvc/llvm-project?rev=250327&view=rev
Log:
Get Python unit tests working with Python 3.
There were a couple of issues related to string handling that
needed to be fixed. In particular, we cannot get away w
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D13742
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
Author: zturner
Date: Wed Oct 14 16:37:36 2015
New Revision: 250331
URL: http://llvm.org/viewvc/llvm-project?rev=250331&view=rev
Log:
Make uses of /dev/null portable across OSes.
Most platforms have "/dev/null". Windows has "nul". Instead of
hardcoding the string /dev/null at various places, ma
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250335: Fix codesign command with cmake. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D13742?vs=37387&id=37405#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13742
Files:
Author: sas
Date: Wed Oct 14 17:25:43 2015
New Revision: 250335
URL: http://llvm.org/viewvc/llvm-project?rev=250335&view=rev
Log:
Fix codesign command with cmake.
Summary:
Looks like having a space in the Xcode path triggers this bug. We need
to use cmake -E env FOO=bar [COMMAND] to set the envir
Author: enrico
Date: Wed Oct 14 17:44:30 2015
New Revision: 250339
URL: http://llvm.org/viewvc/llvm-project?rev=250339&view=rev
Log:
Fix a problem where LLDB could sometimes try to get the size of an Objective-C
type without passing an appropriate ExecutionContext
Modified:
lldb/trunk/inclu
Author: enrico
Date: Wed Oct 14 17:44:50 2015
New Revision: 250340
URL: http://llvm.org/viewvc/llvm-project?rev=250340&view=rev
Log:
Fix a couple issues where trying to print a type would cause LLDB to crash
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/
Author: enrico
Date: Wed Oct 14 17:45:04 2015
New Revision: 250341
URL: http://llvm.org/viewvc/llvm-project?rev=250341&view=rev
Log:
Add a data formatter for __NSArray0, the type of empty arrays
Modified:
lldb/trunk/source/Plugins/Language/ObjC/NSArray.cpp
lldb/trunk/source/Plugins/Langua
ovyalov created this revision.
ovyalov added reviewers: clayborg, zturner, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
There are a few reasons for this change:
- Support generic logic flow for different socket types - a preparation
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Can we change "TcpSocket" to be "TCPSocket" and "UdpSocket" to be "UDPSocket"
in all code and in the file names? Other than that it looks good.
Comment at: sour
Author: gclayton
Date: Wed Oct 14 19:49:36 2015
New Revision: 250353
URL: http://llvm.org/viewvc/llvm-project?rev=250353&view=rev
Log:
Fix the ability to quit and use a custom exception. Also print tree items out
so they are more aligned.
Modified:
lldb/trunk/test/lldbcurses.py
Modified: l
zturner added a comment.
Can you compile on Windows and make sure it works? Also should you add a
unittest for Udp Sockets?
http://reviews.llvm.org/D13754
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: jmolenda
Date: Wed Oct 14 23:20:42 2015
New Revision: 250364
URL: http://llvm.org/viewvc/llvm-project?rev=250364&view=rev
Log:
In r240466, when Greg added the jThreadsInfo packet, he accidentally
disabled the use of the jThreadGetExtendedInfo packet which is used
to retrieve additional inf
70 matches
Mail list logo
