labath added a comment.
In http://reviews.llvm.org/D13362#258972, @tfiala wrote:
> I've fixed:
> https://llvm.org/bugs/show_bug.cgi?id=25019
>
> I think for now I am not interested in trying to tackle the intent of this
> change as it unduly complicates the timeout detection logic.
>
> I am oka
jaydeep accepted this revision.
jaydeep added a comment.
This revision is now accepted and ready to land.
Looks good
Repository:
rL LLVM
http://reviews.llvm.org/D13335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249299: [LLDB][MIPS] Skip invalid size watchpoint testcase
for MIPS (authored by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D13335?vs=36212&id=36498#toc
Repository:
rL LLVM
htt
Author: mohit.bhakkad
Date: Mon Oct 5 05:56:19 2015
New Revision: 249299
URL: http://llvm.org/viewvc/llvm-project?rev=249299&view=rev
Log:
[LLDB][MIPS] Skip invalid size watchpoint testcase for MIPS
Reviewers: jaydeep.
Subscribers: lldb-commits.
Differential Revision: http://reviews.llvm.org/D13
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13154
___
lldb-commits mailing list
lldb
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This can't be the real fix for this. We must be able to trust the empty()
function call. We must have someone playing with the collection without locking
the mutex. Please find t
zturner added a subscriber: zturner.
zturner added a comment.
You should add a test for this. You might need a `@skipIfNotMips` decorator
Repository:
rL LLVM
http://reviews.llvm.org/D13154
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
tfiala added a comment.
And if you'd prefer, I'd be happy to put in that patch as is (the one I tested
with both libedit included and libedit excluded).
Repository:
rL LLVM
http://reviews.llvm.org/D13268
___
lldb-commits mailing list
lldb-commit
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Back from vacation, sorry for the delay.
One quick fix as noted in inlined comments.
Comment at: source/Breakpoint/Watchpoint.cpp:224-235
@@ -223,7 +223,14 @@
clayborg added a comment.
So this fix is really to take care of the case where a class methods might be
defined on only some class instances? Can you explain more of what this fixes?
http://reviews.llvm.org/D13224
___
lldb-commits mailing list
lldb
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13247
___
lldb-commits mailing list
lldb
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13149
___
lldb-commits mailing list
lldb
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
http://reviews.llvm.org/D13270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
http://reviews.llvm.org/D13271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tfiala added a comment.
In http://reviews.llvm.org/D13362#259543, @labath wrote:
> In http://reviews.llvm.org/D13362#258972, @tfiala wrote:
>
> > I've fixed:
> > https://llvm.org/bugs/show_bug.cgi?id=25019
> >
> > I think for now I am not interested in trying to tackle the intent of this
> > ch
clayborg accepted this revision.
clayborg added a comment.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13282
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
Oops, missed this. I see how it can be gnarly finding things in
lldb-commits!
On Sat, Oct 3, 2015 at 7:25 PM, Zachary Turner wrote:
> You just reminded me. Since you've been hitting a lot of this stuff
> lately and doing a lot of great cleanup work, how do you feel about
> integrating the sw
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13241
___
lldb-commits mailing list
lldb
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will defer to Jim Ingham on this one.
Repository:
rL LLVM
http://reviews.llvm.org/D13296
___
lldb-commits mailing list
lldb-commits@lists.llv
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
http://reviews.llvm.org/D13300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
DeclBase.h will need to be submitted against clang, not LLDB.
Then add Sean Callanan and Jim Ingham as the reviewers as they are the masters
of the expression parser. I helped to get the Compil
So on the Xcode side, there is a script that runs called
`build-swig-wrapper-classes.sh` that converts the SWIG into python stuff.
On the Windows side, there's no such thing as shell scripts, so we wrote
python scripts instead. It's called buildSwigWrapperClasses.py, in the
same folder ad the shel
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good if Enrico is happy.
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-com
clayborg accepted this revision.
clayborg added a comment.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13201
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
Oh I see what you mean.
Yeah that would be easy enough to do. I'll put it on a cleanup-priority
list. (Not promising I'll hit it very soon but I will do it).
On Mon, Oct 5, 2015 at 1:08 PM, Zachary Turner wrote:
> So on the Xcode side, there is a script that runs called
> `build-swig-wrapper-
Filed this bugzilla bug:
https://llvm.org/bugs/show_bug.cgi?id=25062
to capture.
On Mon, Oct 5, 2015 at 1:12 PM, Todd Fiala wrote:
> Oh I see what you mean.
>
> Yeah that would be easy enough to do. I'll put it on a cleanup-priority
> list. (Not promising I'll hit it very soon but I will do i
zturner updated this revision to Diff 36544.
zturner added a comment.
Updated from Vadim's comments.
http://reviews.llvm.org/D13404
Files:
cmake/modules/LLDBConfig.cmake
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalone.cmake
===
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
Todd, I'm putting you as the reviewer since you seem to be the most
knowledgeable about Python. If you can think of someone better, let me know.
The goal here is for these scripts to be ab
tfiala added a comment.
> Todd, I'm putting you as the reviewer since you seem to be the most
> knowledgeable about Python. If you can think of someone better, let me know.
I'll have a look tonight.
http://reviews.llvm.org/D13448
___
lldb-commits
tfiala added a comment.
In http://reviews.llvm.org/D13448#260194, @tfiala wrote:
> > Todd, I'm putting you as the reviewer since you seem to be the most
> > knowledgeable about Python. If you can think of someone better, let me know.
>
>
> I'll have a look tonight.
I may try to switch over the
Author: gclayton
Date: Mon Oct 5 17:58:37 2015
New Revision: 249361
URL: http://llvm.org/viewvc/llvm-project?rev=249361&view=rev
Log:
SBTarget::Attach(SBAttachInfo &) was changed to not be asynchronous back in
February and this affected Xcode's abililty to cancel an attach to process by
name.
Author: enrico
Date: Mon Oct 5 20:02:47 2015
New Revision: 249366
URL: http://llvm.org/viewvc/llvm-project?rev=249366&view=rev
Log:
Introduce a FormattersMatchData class which contains all the information that
data formatters need in one place, and also allows for lazy computation of
expensive
enlight added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:113
@@ +112,3 @@
+ set (PYTHON_LIBRARY ${PYTHON_LIBRARY} PARENT_SCOPE)
+ set (PYTHON_DLL ${PYTHON_LIBRARY} PYTHON_DLL PARENT_SCOPE)
+ set (PYTHON_INCLUDE_DIRS ${PYTHON_INCLUDE_DIRS} PARENT_SCOPE)
Author: mohit.bhakkad
Date: Tue Oct 6 00:25:17 2015
New Revision: 249377
URL: http://llvm.org/viewvc/llvm-project?rev=249377&view=rev
Log:
[LLDB][MIPS] Fix hit_count for mips watchpoints
Reviewers: clayborg, jingham.
Subscribers: jaydeep, bhushan, dsanders, sagar, nitesh.jain, zturner,
jasonmol
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249377: [LLDB][MIPS] Fix hit_count for mips watchpoints
(authored by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D13241?vs=35958&id=36583#toc
Repository:
rL LLVM
http://reviews.
tfiala added a comment.
In http://reviews.llvm.org/D13448#260195, @tfiala wrote:
> In http://reviews.llvm.org/D13448#260194, @tfiala wrote:
>
> > > Todd, I'm putting you as the reviewer since you seem to be the most
> > > knowledgeable about Python. If you can think of someone better, let me
>
tfiala added a comment.
Okay all that said, the change itself looks fine. Have you tried it on Linux?
I'll give it a go there in the morning. If it doesn't break there, I have no
issues with this change.
http://reviews.llvm.org/D13448
___
lldb-c
37 matches
Mail list logo
