Re: [Lldb-commits] [PATCH] D12976: Update TestChangeProcessGroup to remove obsolete workaround.

2015-09-22 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. That shouln't be needed anymore, thanks. http://reviews.llvm.org/D12976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-22 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL248248 Repository: rL LLVM http://reviews.llvm.org/D12079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

2015-09-22 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. Hi Jason, thanks for your suggestions. Yes, this approach looks good and one time warning should be helpful from users view, I will implement it get back with a patch soon. Repository: rL LLVM http://reviews.llvm.org/D12877 _

[Lldb-commits] [lldb] r248251 - [lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree.

2015-09-22 Thread Daniel Sanders via lldb-commits
Author: dsanders Date: Tue Sep 22 04:08:44 2015 New Revision: 248251 URL: http://llvm.org/viewvc/llvm-project?rev=248251&view=rev Log: [lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree. Subscribers: krytarowski, labath, lldb-commits Differential Revision: http://reviews.llvm.or

Re: [Lldb-commits] [PATCH] D13027: [lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree.

2015-09-22 Thread Daniel Sanders via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248251: [lldb-mi] Fix unresolved reference to llvm_regcomp and llvm_regfree. (authored by dsanders). Changed prior to commit: http://reviews.llvm.org/D13027?vs=35278&id=35351#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13022: Use fcntl.h to retrieve the O_CREAT and O_RDRW constants.

2015-09-22 Thread Vasileios Kalintiris via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248255: Use fcntl.h to retrieve the O_CREAT and O_RDWR constants. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D13022?vs=35258&id=35352#toc Repository: rL LLVM http://

[Lldb-commits] [lldb] r248255 - Use fcntl.h to retrieve the O_CREAT and O_RDWR constants.

2015-09-22 Thread Vasileios Kalintiris via lldb-commits
Author: vkalintiris Date: Tue Sep 22 04:46:35 2015 New Revision: 248255 URL: http://llvm.org/viewvc/llvm-project?rev=248255&view=rev Log: Use fcntl.h to retrieve the O_CREAT and O_RDWR constants. Summary: Normally, these macros are defined in fnctl.h. However, GLIBC exposes their definition throu

[Lldb-commits] [lldb] r248256 - Check for GLIBC before including execinfo.h

2015-09-22 Thread Vasileios Kalintiris via lldb-commits
Author: vkalintiris Date: Tue Sep 22 04:53:30 2015 New Revision: 248256 URL: http://llvm.org/viewvc/llvm-project?rev=248256&view=rev Log: Check for GLIBC before including execinfo.h Reviewers: ovyalov, clayborg Subscribers: tberghammer, danalbert, llvm-commits, srhines Differential Revision: ht

[Lldb-commits] [PATCH] D13049: execinfo.h isn't needed on Mac OS X for Host.mm.

2015-09-22 Thread Bruce Mitchener via lldb-commits
brucem created this revision. brucem added a reviewer: clayborg. brucem added a subscriber: lldb-commits. This is no longer needed as this file no longer calls backtrace(). http://reviews.llvm.org/D13049 Files: source/Host/macosx/Host.mm Index: source/Host/macosx/Host.mm =

Re: [Lldb-commits] [PATCH] D13019: Do not use pthread_{get, set}name_np() if we don't have GLIBC.

2015-09-22 Thread Vasileios Kalintiris via lldb-commits
vkalintiris updated this revision to Diff 35357. vkalintiris added a comment. Herald added subscribers: srhines, danalbert, tberghammer. Addressed reviewers comments. http://reviews.llvm.org/D13019 Files: source/Host/linux/HostThreadLinux.cpp Index: source/Host/linux/HostThreadLinux.cpp

Re: [Lldb-commits] [PATCH] D13019: Do not use pthread_{get, set}name_np() if we don't have GLIBC.

2015-09-22 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. looks good http://reviews.llvm.org/D13019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

[Lldb-commits] [lldb] r248268 - Remove unused header .

2015-09-22 Thread Vasileios Kalintiris via lldb-commits
Author: vkalintiris Date: Tue Sep 22 07:43:23 2015 New Revision: 248268 URL: http://llvm.org/viewvc/llvm-project?rev=248268&view=rev Log: Remove unused header . Modified: lldb/trunk/source/Host/linux/Host.cpp Modified: lldb/trunk/source/Host/linux/Host.cpp URL: http://llvm.org/viewvc/llvm-p

[Lldb-commits] [lldb] r248269 - Remove expectedFailureFreeBSD from passing test

2015-09-22 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Sep 22 08:27:26 2015 New Revision: 248269 URL: http://llvm.org/viewvc/llvm-project?rev=248269&view=rev Log: Remove expectedFailureFreeBSD from passing test HelloWorldTestCase::test_with_dwarf_and_process_launch_api passes consistently for me and for John Wolfe. llvm.org/

[Lldb-commits] [lldb] r248271 - Remove expectedFailureFreeBSD from passing tests

2015-09-22 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Sep 22 08:31:16 2015 New Revision: 248271 URL: http://llvm.org/viewvc/llvm-project?rev=248271&view=rev Log: Remove expectedFailureFreeBSD from passing tests These two tests are skipped on Linux with a comment that the behaviour is as expected, but they are consistently pa

[Lldb-commits] [lldb] r248274 - RenderScript lookup bug fix

2015-09-22 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Tue Sep 22 08:36:35 2015 New Revision: 248274 URL: http://llvm.org/viewvc/llvm-project?rev=248274&view=rev Log: RenderScript lookup bug fix After the std::move operation the unique pointer is null. So this statement always returns a null pointer. Also remove unnecess

[Lldb-commits] [PATCH] D13056: Fix race condition during process detach

2015-09-22 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: jingham, clayborg. labath added a subscriber: lldb-commits. The following situation occured in TestAttachResume: The inferior was stoped at a breakpoint and we did a continue, immediately followed by a detach. Since there was a trap instructi

Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

2015-09-22 Thread Pavel Labath via lldb-commits
labath updated this revision to Diff 35372. labath added a comment. remove some binaries that managed to sneak in http://reviews.llvm.org/D13056 Files: include/lldb/Target/Process.h source/Target/Process.cpp test/functionalities/attach_resume/TestAttachResume.py Index: test/functionaliti

[Lldb-commits] [lldb] r248277 - [MIPS32] Emulate MSA instructions for MIPS32

2015-09-22 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Tue Sep 22 08:57:11 2015 New Revision: 248277 URL: http://llvm.org/viewvc/llvm-project?rev=248277&view=rev Log: [MIPS32] Emulate MSA instructions for MIPS32 This patch adds MSA branch instruction emulation for MIPS32. Reviewers: tberghammer, jaydeep Subscribers: mohit.bhak

Re: [Lldb-commits] [Diffusion] rL248277: [MIPS32] Emulate MSA instructions for MIPS32

2015-09-22 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: lldb-commits. http://reviews.llvm.org/rL248277 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [Diffusion] rL248277: [MIPS32] Emulate MSA instructions for MIPS32

2015-09-22 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer raised a concern with this commit. tberghammer added a comment. Hi Sagar, This change break the Linux build (http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/6568) because the register enums have been renamed recent

Re: [Lldb-commits] [PATCH] D13019: Do not use pthread_{get, set}name_np() if we don't have GLIBC.

2015-09-22 Thread Vasileios Kalintiris via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248280: Do not use pthread_setname_np() if we don't have GLIBC or Android. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D13019?vs=35357&id=35374#toc Repository: rL LLVM

[Lldb-commits] [lldb] r248280 - Do not use pthread_setname_np() if we don't have GLIBC or Android.

2015-09-22 Thread Vasileios Kalintiris via lldb-commits
Author: vkalintiris Date: Tue Sep 22 09:52:31 2015 New Revision: 248280 URL: http://llvm.org/viewvc/llvm-project?rev=248280&view=rev Log: Do not use pthread_setname_np() if we don't have GLIBC or Android. Summary: pthread_setname_np() is a nonstandard GNU extension and isn't available in every C

[Lldb-commits] [lldb] r248281 - Fix register names in EmulateInstructionMIPS.cpp

2015-09-22 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Sep 22 10:04:39 2015 New Revision: 248281 URL: http://llvm.org/viewvc/llvm-project?rev=248281&view=rev Log: Fix register names in EmulateInstructionMIPS.cpp Modified: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp Modified: lldb/trunk/sour

Re: [Lldb-commits] [Diffusion] rL248277: [MIPS32] Emulate MSA instructions for MIPS32

2015-09-22 Thread Tamas Berghammer via lldb-commits
tberghammer resigned from this audit. tberghammer added a comment. I committed in a build fix as http://reviews.llvm.org/rL248281 Users: tberghammer (Auditor) http://reviews.llvm.org/rL248277 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] r248282 - test runner: Unix systems now put inferior dotest in its own process group.

2015-09-22 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Tue Sep 22 10:21:50 2015 New Revision: 248282 URL: http://llvm.org/viewvc/llvm-project?rev=248282&view=rev Log: test runner: Unix systems now put inferior dotest in its own process group. This increases isolation as it relates to signal handling between parent and children.

[Lldb-commits] [lldb] r248284 - Roll back r248282.

2015-09-22 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Tue Sep 22 11:03:43 2015 New Revision: 248284 URL: http://llvm.org/viewvc/llvm-project?rev=248284&view=rev Log: Roll back r248282. I'm seeing timed out tests not properly timing out on the Linux build bot after this change. Not sure if it is related but seems suspect. Modif

[Lldb-commits] [lldb] r248285 - Add missing file that contains the curses test suite code. To run with curses you now execute:

2015-09-22 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Sep 22 11:29:15 2015 New Revision: 248285 URL: http://llvm.org/viewvc/llvm-project?rev=248285&view=rev Log: Add missing file that contains the curses test suite code. To run with curses you now execute: % ./dotest.py --results-formatter=curses_results.Curses --result

[Lldb-commits] [lldb] r248286 - Remove IRToDWARF.h

2015-09-22 Thread Bruce Mitchener via lldb-commits
Author: brucem Date: Tue Sep 22 11:30:26 2015 New Revision: 248286 URL: http://llvm.org/viewvc/llvm-project?rev=248286&view=rev Log: Remove IRToDWARF.h Summary: The corresponding .cpp file was removed in September of 2011 in r139772. Reviewers: spyffe, clayborg Subscribers: lldb-commits Differ

Re: [Lldb-commits] [PATCH] D13039: Rename clang_type_t to opaque_t.

2015-09-22 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. We should switch all of TypeSystem's methods over to use this instead of "void *" as well in a future commit. http://reviews.llvm.org/D13039 ___

Re: [Lldb-commits] [PATCH] D13039: Rename clang_type_t to opaque_t.

2015-09-22 Thread Bruce Mitchener via lldb-commits
brucem added a comment. I already have that as a commit lined up. Just wanted this to land separately first. :) http://reviews.llvm.org/D13039 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [Lldb-commits] [PATCH] D13043: Remove IRToDWARF.h

2015-09-22 Thread Bruce Mitchener via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248286: Remove IRToDWARF.h (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13043?vs=35340&id=35377#toc Repository: rL LLVM http://reviews.llvm.org/D13043 Files: lldb/trunk/

[Lldb-commits] [lldb] r248288 - Rename clang_type_t to opaque_compiler_type_t.

2015-09-22 Thread Bruce Mitchener via lldb-commits
Author: brucem Date: Tue Sep 22 12:04:24 2015 New Revision: 248288 URL: http://llvm.org/viewvc/llvm-project?rev=248288&view=rev Log: Rename clang_type_t to opaque_compiler_type_t. Summary: This is no longer related to Clang and is just an opaque pointer to data for a compiler type. Reviewers: cl

Re: [Lldb-commits] [PATCH] D13039: Rename clang_type_t to opaque_t.

2015-09-22 Thread Bruce Mitchener via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248288: Rename clang_type_t to opaque_compiler_type_t. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13039?vs=35339&id=35382#toc Repository: rL LLVM http://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

2015-09-22 Thread Zachary Turner via lldb-commits
I am at CppCon all week. If you need to get this in before Monday, can you have Oleksiy or Chaoren test on Windows? Otherwise I can take a look next week. On Tue, Sep 22, 2015 at 9:51 AM Tamas Berghammer wrote: > tberghammer retitled this revision from "[RFC] Merge dsym and dwarf test > cases"

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

2015-09-22 Thread Zachary Turner via lldb-commits
zturner added a comment. I am at CppCon all week. If you need to get this in before Monday, can you have Oleksiy or Chaoren test on Windows? Otherwise I can take a look next week. http://reviews.llvm.org/D13028 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D13060: Use opaque_compiler_type_t in place of void*.

2015-09-22 Thread Bruce Mitchener via lldb-commits
brucem created this revision. brucem added a reviewer: clayborg. brucem added a subscriber: lldb-commits. http://reviews.llvm.org/D13060 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerType.h include/lldb/Symbol/GoASTContext.h include/lldb/Symbol/TaggedASTType.h

[Lldb-commits] [lldb] r248290 - Allow TAB key to switch first responder when tests are running or completed.

2015-09-22 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Sep 22 12:18:15 2015 New Revision: 248290 URL: http://llvm.org/viewvc/llvm-project?rev=248290&view=rev Log: Allow TAB key to switch first responder when tests are running or completed. Typing the shortcut key ('.' for 'pass', 'e' for 'error', etc) will toggle the visib

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-22 Thread Kirill Lapshin via lldb-commits
KLapshin updated the summary for this revision. KLapshin updated this revision to Diff 35390. Repository: rL LLVM http://reviews.llvm.org/D12968 Files: source/Target/Process.cpp Index: source/Target/Process.cpp === --- source/T

Re: [Lldb-commits] [PATCH] D13060: Use opaque_compiler_type_t in place of void*.

2015-09-22 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

2015-09-22 Thread Ilia K via lldb-commits
ki.stfu added a subscriber: lldb-commits. ki.stfu added a comment. Please always add lldb-commits to subscribers http://reviews.llvm.org/D13058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

2015-09-22 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. For the failing test cases, just check this stuff in and we should take care or marking any needed tests and expected fail. Is there a way to mark a test such that the "dwarf i

Re: [Lldb-commits] [PATCH] D13056: Fix race condition during process detach

2015-09-22 Thread Kirill Lapshin via lldb-commits
KLapshin added a comment. See http://reviews.llvm.org/D12968 also - fix for missed hijacked listener set in Process::HaltForDestroyOrDetach() http://reviews.llvm.org/D13056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

[Lldb-commits] [lldb] r248301 - Update TestChangeProcessGroup to remove obsolete workaround.

2015-09-22 Thread Chaoren Lin via lldb-commits
Author: chaoren Date: Tue Sep 22 12:37:34 2015 New Revision: 248301 URL: http://llvm.org/viewvc/llvm-project?rev=248301&view=rev Log: Update TestChangeProcessGroup to remove obsolete workaround. Expression evaluation in syscalls should work now. Reviewers: labath Subscribers: lldb-commits Diff

Re: [Lldb-commits] [PATCH] D12976: Update TestChangeProcessGroup to remove obsolete workaround.

2015-09-22 Thread Chaoren Lin via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248301: Update TestChangeProcessGroup to remove obsolete workaround. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D12976?vs=35304&id=35391#toc Repository: rL LLVM http://r

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-22 Thread Kirill Lapshin via lldb-commits
KLapshin updated this revision to Diff 35392. Repository: rL LLVM http://reviews.llvm.org/D12968 Files: source/Target/Process.cpp Index: source/Target/Process.cpp === --- source/Target/Process.cpp +++ source/Target/Process.cpp

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-22 Thread Kirill Lapshin via lldb-commits
KLapshin added a comment. Greg, I reworked initial workaround solution, now this is exact fix. Repository: rL LLVM http://reviews.llvm.org/D12968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

2015-09-22 Thread Zachary Turner via lldb-commits
zturner added a comment. At some point I really would love to reduce the number of decorators. It's starting to get ridiculous :) Seems like we only need one decorator that takes everything as optional arguments http://reviews.llvm.org/D13028 ___

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

2015-09-22 Thread Zachary Turner via lldb-commits
At some point I really would love to reduce the number of decorators. It's starting to get ridiculous :) Seems like we only need one decorator that takes everything as optional arguments On Tue, Sep 22, 2015 at 10:42 AM Tamas Berghammer wrote: > tberghammer added a comment. > > In http://revie

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

2015-09-22 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. In http://reviews.llvm.org/D13028#250822, @clayborg wrote: > Looks good. For the failing test cases, just check this stuff in and we > should take care or marking any needed tests and expected fail. Is there a > way to mark a test such that the "dwarf in .o files" w

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-22 Thread Kirill Lapshin via lldb-commits
KLapshin added a subscriber: labath. KLapshin added a comment. Due to @labath reworked and replaced HaltForDestroyOrDetach to StopHaltForDestroyOrDetach method (see http://reviews.llvm.org/D13056) and his patch already approved by @clayborg and crash still reproducible with just race condition

[Lldb-commits] [lldb] r248306 - Test runner process group isolation take 2.

2015-09-22 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Tue Sep 22 13:05:11 2015 New Revision: 248306 URL: http://llvm.org/viewvc/llvm-project?rev=248306&view=rev Log: Test runner process group isolation take 2. This one does not create a session, but just creates a new process group in the same session. Modified: lldb/trunk/

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

2015-09-22 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. You can't use std::string in the public API. Use lldb::SBStream as noted in inlined comments. Comment at: include/lldb/API/SBValue.h:132-133 @@ -131,1 +131,4 @@

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

2015-09-22 Thread Enrico Granata via lldb-commits
granata.enrico added a subscriber: granata.enrico. granata.enrico requested changes to this revision. granata.enrico added a reviewer: granata.enrico. granata.enrico added a comment. Is there a reason to explicitly add an API to get the concatenation of value and summary? We already have APIs to

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

2015-09-22 Thread Greg Clayton via lldb-commits
clayborg added a comment. As Enrico stated. there is already a SBStream based way to get the summary in "const char * SBValueGetSummary (lldb::SBStream& stream, lldb::SBTypeSummaryOptions& options);" so no need to add anything as I had suggested. http://reviews.llvm.org/D13058

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

2015-09-22 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Gotcha! My suggestion would be to add the DoesPrintValue() logic to SBTypeSummary. I can't recall if it's there already - but if not, it would be a fine thing to add. Then the MI could use SBValue and SBTypeSummary to make that determination as it sees fit. ht

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

2015-09-22 Thread Eugene Leviant via lldb-commits
evgeny777 added a comment. Yes I know about GetValue() and stuff Actually I implemented new method, because I needed TypeSummaryImpl::DoesPrintValue(). In lldb when you evaluate char*, you get both value and summary, for example: 0xdeadbeef "hello" But when you evaluate char[] array, you get ju

[Lldb-commits] [lldb] r248315 - Move the logic to post-process dynamic types for ValueObject purposes from the ValueObjects to the LanguageRuntime plugins

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 14:45:52 2015 New Revision: 248315 URL: http://llvm.org/viewvc/llvm-project?rev=248315&view=rev Log: Move the logic to post-process dynamic types for ValueObject purposes from the ValueObjects to the LanguageRuntime plugins This is meant to cover cases such as the

[Lldb-commits] [lldb] r248316 - On second thought, amend the previous patch to pass itself the ValueObject& for the static value instead of just its type

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 14:58:02 2015 New Revision: 248316 URL: http://llvm.org/viewvc/llvm-project?rev=248316&view=rev Log: On second thought, amend the previous patch to pass itself the ValueObject& for the static value instead of just its type Modified: lldb/trunk/include/lldb/Ta

[Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

2015-09-22 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added a reviewer: clayborg. sivachandra added a subscriber: lldb-commits. The return value is false if any of the child members have incomplete type info. This helps in cases like these: class Foo { public: std::string str; }; ... Foo f; If a fi

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

2015-09-22 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 35410. sivachandra added a comment. Fix few copy-paste typos. http://reviews.llvm.org/D13066 Files: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h test/lang/cpp/incomplete-types/Makefi

[Lldb-commits] [lldb] r248323 - test framework: default to threading-based test runners

2015-09-22 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Tue Sep 22 16:19:40 2015 New Revision: 248323 URL: http://llvm.org/viewvc/llvm-project?rev=248323&view=rev Log: test framework: default to threading-based test runners Windows gets threading-pool, OS X versions < 10.10 get multiprocessing, everyone else gets threading. Modif

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

2015-09-22 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We have the same problem with base classes where if we have a class that has a DW_TAG_inheritance tag that points to a forward declaration for a class, then we start and end the

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

2015-09-22 Thread Greg Clayton via lldb-commits
clayborg added a comment. Emitting a warning is a good idea as well if the compiler is clang and how to fix it (something like "please specify -fno-limit-debug-info ...") http://reviews.llvm.org/D13066 ___ lldb-commits mailing list lldb-commits@lis

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

2015-09-22 Thread Greg Clayton via lldb-commits
clayborg added a comment. We also need to make sure that if the class is specified anywhere else within the current binary (in another .o file), that we find that class definition and use it in place of the forward declaration. So if you can make another test with the same source file, and anot

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

2015-09-22 Thread Siva Chandra via lldb-commits
sivachandra added a comment. I did not touch the base classes part because there is a comment in DWARFASTParserClang::CompleteTypeFromDWARF as: // We have no choice other than to pretend that the base class // is complete. If we don't do this, clang will crash when we // call setBases() in

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

2015-09-22 Thread Siva Chandra via lldb-commits
sivachandra added a comment. I have read that part of the code more closely now. It does look like it might need some fixing. Will address all your comments and send a newer version shortly. http://reviews.llvm.org/D13066 ___ lldb-commits mailing

[Lldb-commits] [lldb] r248337 - test runner: remove print from prior commit; fixup listner socket backlog

2015-09-22 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Tue Sep 22 17:47:34 2015 New Revision: 248337 URL: http://llvm.org/viewvc/llvm-project?rev=248337&view=rev Log: test runner: remove print from prior commit; fixup listner socket backlog When doing test event collation from dotest inferiors to the parallel test runner, I had a

[Lldb-commits] [lldb] r248338 - Move the "run" alias from process launch --shell to process launch --shell-expand-args when building on OS X

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 17:57:12 2015 New Revision: 248338 URL: http://llvm.org/viewvc/llvm-project?rev=248338&view=rev Log: Move the "run" alias from process launch --shell to process launch --shell-expand-args when building on OS X The argdumper-based launching is more friendly to Syste

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

2015-09-22 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. LGTM as well. Thanks! http://reviews.llvm.org/D13028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248339 - Fix a test case which was failing. There was no actual problem in the test logic, just a cosmetic issue with the presentation of the result by Foundation

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 18:08:13 2015 New Revision: 248339 URL: http://llvm.org/viewvc/llvm-project?rev=248339&view=rev Log: Fix a test case which was failing. There was no actual problem in the test logic, just a cosmetic issue with the presentation of the result by Foundation Modified:

[Lldb-commits] [lldb] r248343 - A small fixup needed for debugserver to work natively

2015-09-22 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Sep 22 18:25:44 2015 New Revision: 248343 URL: http://llvm.org/viewvc/llvm-project?rev=248343&view=rev Log: A small fixup needed for debugserver to work natively on iOS devices; fallout from Vince's cleanups made in r237218 back in May. iOS native lldbs will call StartD

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

2015-09-22 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 35444. sivachandra added a comment. Address comments. http://reviews.llvm.org/D13066 Files: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h test/lang/cpp/incomplete-types/Makefile tes

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-22 Thread Siva Chandra via lldb-commits
sivachandra added a comment. I am not sure how portable my Makefile is. I have no idea if it will work on Windows for example. http://reviews.llvm.org/D13066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] r248352 - Use opaque_compiler_type_t in place of void*.

2015-09-22 Thread Bruce Mitchener via lldb-commits
Author: brucem Date: Tue Sep 22 19:18:24 2015 New Revision: 248352 URL: http://llvm.org/viewvc/llvm-project?rev=248352&view=rev Log: Use opaque_compiler_type_t in place of void*. Reviewers: clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D13060 Modified: l

Re: [Lldb-commits] [PATCH] D13060: Use opaque_compiler_type_t in place of void*.

2015-09-22 Thread Bruce Mitchener via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248352: Use opaque_compiler_type_t in place of void*. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13060?vs=35383&id=35447#toc Repository: rL LLVM http://reviews.llvm.org/

[Lldb-commits] [lldb] r248359 - Add {TypeSystem|CompilerType}::GetTypeForFormatters()

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 20:39:46 2015 New Revision: 248359 URL: http://llvm.org/viewvc/llvm-project?rev=248359&view=rev Log: Add {TypeSystem|CompilerType}::GetTypeForFormatters() Different type system may have different notions of attributes of a type that do not matter for data formatte

[Lldb-commits] [lldb] r248363 - Allow CompilerType to express a vote on whether oneliner printing should happen

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 21:04:34 2015 New Revision: 248363 URL: http://llvm.org/viewvc/llvm-project?rev=248363&view=rev Log: Allow CompilerType to express a vote on whether oneliner printing should happen Modified: lldb/trunk/include/lldb/Symbol/CompilerType.h lldb/trunk/include/

[Lldb-commits] [lldb] r248364 - Fix indentation in ExpressionParser.h.

2015-09-22 Thread Bruce Mitchener via lldb-commits
Author: brucem Date: Tue Sep 22 21:23:02 2015 New Revision: 248364 URL: http://llvm.org/viewvc/llvm-project?rev=248364&view=rev Log: Fix indentation in ExpressionParser.h. Modified: lldb/trunk/include/lldb/Expression/ExpressionParser.h Modified: lldb/trunk/include/lldb/Expression/ExpressionP

[Lldb-commits] [PATCH] D13084: Fix covered-switch-default warning in FormatManager.

2015-09-22 Thread Bruce Mitchener via lldb-commits
brucem created this revision. brucem added reviewers: granata.enrico, clayborg. brucem added a subscriber: lldb-commits. The default case doesn't need to be here as the switch covers all possible values. If there's a new "lazy bool" value added in the future, the compiler would start to warn about

Re: [Lldb-commits] [PATCH] D13084: Fix covered-switch-default warning in FormatManager.

2015-09-22 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13084 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] r248365 - Fix covered-switch-default warning in FormatManager.

2015-09-22 Thread Bruce Mitchener via lldb-commits
Author: brucem Date: Tue Sep 22 21:33:30 2015 New Revision: 248365 URL: http://llvm.org/viewvc/llvm-project?rev=248365&view=rev Log: Fix covered-switch-default warning in FormatManager. Summary: The default case doesn't need to be here as the switch covers all possible values. If there's a new "l

Re: [Lldb-commits] [PATCH] D13084: Fix covered-switch-default warning in FormatManager.

2015-09-22 Thread Bruce Mitchener via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248365: Fix covered-switch-default warning in FormatManager. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13084?vs=35454&id=35456#toc Repository: rL LLVM http://reviews.ll

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-22 Thread Ilia K via lldb-commits
ki.stfu added a reviewer: jingham. ki.stfu added a subscriber: jingham. ki.stfu added a comment. +@jingham for changes in Target. Comment at: source/Target/Process.cpp:3934 @@ +3933,3 @@ + +ListenerSP listener_sp (new Listener("lldb.Process.HaltForDestroyOrDetach.hi