[Lldb-commits] [PATCH] D12830: Limit scope of RegisterContextPOSIX.h header

2015-09-12 Thread Ed Maste via lldb-commits
emaste created this revision. emaste added reviewers: tfiala, labath. emaste added a subscriber: lldb-commits. Herald added a subscriber: emaste. RegisterContextPOSIX.h is poorly named and contains only the declaration of POSIXBreakpointProtocol, which is used for in-process live kernel debugging

[Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

2015-09-12 Thread Todd Fiala via lldb-commits
tfiala created this revision. tfiala added reviewers: clayborg, zturner. tfiala added a subscriber: lldb-commits. Add JUnit/XUnit-formatted output to the lldb test run system h1. Test Events h2. Overview This change introduces a test-event-based mechanism and a manner to format test events to a

Re: [Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

2015-09-12 Thread Todd Fiala via lldb-commits
tfiala added a comment. @zturner, if you could check that this runs on Windows, that would be great. (I've been able to test with Linux Jenkins and OS X Jenkins, in addition to hand running). You should just need to run like this: python /your/dotest.py {your-normal-options} --results-file

Re: [Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

2015-09-12 Thread Todd Fiala via lldb-commits
tfiala added inline comments. Comment at: test/settings/TestSettings.py:168 @@ -167,3 +167,3 @@ -@skipUnlessArch(['x86-64', 'i386', 'i686']) +@skipUnlessArch(['x86_64', 'i386', 'i686']) def test_disassembler_settings(self): This was a test spec fail

Re: [Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

2015-09-12 Thread Todd Fiala via lldb-commits
tfiala added a comment. A couple notes on this: - Failures don't currently capture backtraces. I can add this later, but I am leaving it for another pass. This change is big enough as is. Right now I'm focusing on counts and green/red CI solutions. - Tests don't capture testcase-specific std

Re: [Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

2015-09-12 Thread Zachary Turner via lldb-commits
I can't check this until Monday. But drive by comment: Why do we need the MAPMODE? Can't the JUnitFormatter just treat xpasses as whatever it wants without the help of this option? Also, I'm not really familiar with JUnit as a general tool. Is there some reason a one-size-fits-all JSON formatte

Re: [Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

2015-09-12 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D12831#244935, @zturner wrote: > I can't check this until Monday. No worries, that is fine. But drive by comment: Why do we need the > MAPMODE? Can't the JUnitFormatter just treat xpasses as whatever it wants > without the help of this o