[Lldb-commits] [PATCH] D12589: SystemRuntime/MacOSX no longer need ObjCRuntime header.

brucem created this revision. brucem added reviewers: clayborg, jasonmolenda. brucem added a subscriber: lldb-commits. The AppleGetQueuesHandler code no longer needs to include a header from the AppleObjCRuntime, so we can remove workarounds that were present in the build systems. http://reviews.

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

labath added subscribers: zturner, labath. labath added a comment. Since we already have an implementation of getopt for windows, couldn't you use that one (or improve/replace it if it is missing some features) for netbsd also? I don't see why it would be necessary to have two independent reimp

Re: [Lldb-commits] [PATCH] D12586: [cmake] Remove LLVM_NO_RTTI.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good http://reviews.llvm.org/D12586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] r246749 - [cmake] Remove LLVM_NO_RTTI.

Author: brucem Date: Thu Sep 3 03:46:55 2015 New Revision: 246749 URL: http://llvm.org/viewvc/llvm-project?rev=246749&view=rev Log: [cmake] Remove LLVM_NO_RTTI. Summary: This doesn't exist in other LLVM projects any longer and doesn't do anything. Reviewers: chaoren, labath Subscribers: emaste

Re: [Lldb-commits] [PATCH] D12586: [cmake] Remove LLVM_NO_RTTI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246749: [cmake] Remove LLVM_NO_RTTI. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12586?vs=33900&id=33911#toc Repository: rL LLVM http://reviews.llvm.org/D12586 Files: l

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

labath added subscribers: chying, labath. labath added a comment. I very much like the direction this is going in. We will need to update our buildbots when this lands (we need to run dosep manually to setup remote testing), but I have tested this manually and didn't see any problems.

[Lldb-commits] [lldb] r246753 - Fix rare failure in TestProcessIO

Author: labath Date: Thu Sep 3 04:30:17 2015 New Revision: 246753 URL: http://llvm.org/viewvc/llvm-project?rev=246753&view=rev Log: Fix rare failure in TestProcessIO Summary: There was a race condition in Process class, where we would not wait for process stdout to propagate fully before we wou

Re: [Lldb-commits] [PATCH] D12558: Fix rare failure in TestProcessIO

This revision was automatically updated to reflect the committed changes. Closed by commit rL246753: Fix rare failure in TestProcessIO (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12558?vs=33815&id=33917#toc Repository: rL LLVM http://reviews.llvm.org/D12558 File

[Lldb-commits] [lldb] r246756 - Fix deadlock while attaching to inferiors

Author: labath Date: Thu Sep 3 04:36:22 2015 New Revision: 246756 URL: http://llvm.org/viewvc/llvm-project?rev=246756&view=rev Log: Fix deadlock while attaching to inferiors Summary: There was a race condition in the AsyncThread, where we would end up sending a vAttach notification to the threa

Re: [Lldb-commits] [PATCH] D12552: Fix deadlock while attaching to inferiors

This revision was automatically updated to reflect the committed changes. Closed by commit rL246756: Fix deadlock while attaching to inferiors (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12552?vs=33795&id=33918#toc Repository: rL LLVM http://reviews.llvm.org/D125

Re: [Lldb-commits] [PATCH] D12584: Fix TestCompletion.py failure on Darwin after r246639

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. I don't understand why it is necessary on OSX but I am fine with this change if it fixes the issue (at the moment I am struggling with building lldb on OSX so I can't test it). One

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski added a comment. I will reuse the Windows version - it comes from some BSD and it's modified. At the moment I don't have a platform to test build it. Please verify whether everything is fine. Repository: rL LLVM http://reviews.llvm.org/D12582 _

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski updated this revision to Diff 33922. krytarowski added a comment. Reuse the Windows' GetOptInc. Repository: rL LLVM http://reviews.llvm.org/D12582 Files: include/lldb/Host/HostGetOpt.h include/lldb/Host/common/GetOptInc.h include/lldb/Host/windows/getopt/GetOptInc.h sourc

Re: [Lldb-commits] [lldb] r246709 - We want Python int or long to both be usable as-a tid_t for API purposes. Introduce a typemap to this effect

Hi, this commit seems to break TestPythonOSPlugin.py on the windows builtbot and I expect any other 32-bit system. It fails with the error "OverflowError: Python int too large to convert to C long", because the test tries to pass

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski added a comment. In case that new commit message was lost, it's here: commit 4193d823f0fdda0799c632c05836c2ed8f26186c Author: Kamil Rytarowski Date: Thu Sep 3 12:10:33 2015 +0200 Move GetOptInc to the common namespace GetOptInc provides getopt(), getopt_long() and getopt_lo

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

labath added a comment. Thanks for merging the two implementations. However, the way you have implemented it enables the getopt replacement for all platforms. We need to have it on only for platforms that don't have a native one. Comment at: include/lldb/Host/HostGetOpt.h:11 @

[Lldb-commits] [lldb] r246761 - Enable TestFdLeak on linux

Author: labath Date: Thu Sep 3 07:00:15 2015 New Revision: 246761 URL: http://llvm.org/viewvc/llvm-project?rev=246761&view=rev Log: Enable TestFdLeak on linux it has been consistently passing at least the last 100 builds on the bot. Modified: lldb/trunk/test/functionalities/avoids-fd-leak/T

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

tberghammer added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:316-328 @@ +315,15 @@ + +const char* dwo_name = cu_die.GetAttributeValueAsString(m_dwarf2Data, +this, +

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski added a comment. I've inlined replies to your comments. Comment at: include/lldb/Host/HostGetOpt.h:11 @@ -10,3 +10,1 @@ -#ifndef _MSC_VER - labath wrote: > How about just putting here > ``` > #if !defined(_MSC_VER) && !defined(__NetBSD__) > ``` I d

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

tberghammer retitled this revision from "Introduce new address class eAddressClassDataIntermixedCode" to "Use eAddressClassCode for address lookup for opcodes". tberghammer updated the summary for this revision. tberghammer updated this revision to Diff 33937. tberghammer added a comment. Addres

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

labath added inline comments. Comment at: include/lldb/Host/HostGetOpt.h:11 @@ -10,3 +10,1 @@ -#ifndef _MSC_VER - krytarowski wrote: > labath wrote: > > How about just putting here > > ``` > > #if !defined(_MSC_VER) && !defined(__NetBSD__) > > ``` > I dislike ha

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski added inline comments. Comment at: include/lldb/Host/HostGetOpt.h:11 @@ -10,3 +10,1 @@ -#ifndef _MSC_VER - labath wrote: > krytarowski wrote: > > labath wrote: > > > How about just putting here > > > ``` > > > #if !defined(_MSC_VER) && !defined(__Net

[Lldb-commits] [lldb] r246766 - XFAIL TestFormatters on android (llvm.org/pr24691)

Author: labath Date: Thu Sep 3 08:52:29 2015 New Revision: 246766 URL: http://llvm.org/viewvc/llvm-project?rev=246766&view=rev Log: XFAIL TestFormatters on android (llvm.org/pr24691) the test is hitting an assertion in clang. Modified: lldb/trunk/test/expression_command/formatters/TestForma

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski updated this revision to Diff 33941. krytarowski added a comment. Apply the latest comments to this patch. Repository: rL LLVM http://reviews.llvm.org/D12582 Files: include/lldb/Host/HostGetOpt.h include/lldb/Host/common/GetOptInc.h include/lldb/Host/windows/getopt/GetOptIn

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

labath added a comment. Looks good after fixing inverting one condition, but I would like to wait for an ok from zachary also. Linux builds fine after this patch. Comment at: source/Host/common/GetOptInc.cpp:3 @@ +2,3 @@ + +#if !defined(REPLACE_GETOPT) && !defined(REPLACE_GETOP

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a comment. In http://reviews.llvm.org/D12587#239054, @labath wrote: > I very much like the direction this is going in. We will need to update our > buildbots when this lands (we need to run dosep manually to setup remote > testing), but I have tested this manually and didn't see an

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added inline comments. Comment at: test/dosep.py:503 @@ +502,3 @@ +"Please call dotest.py directly. The dosep.py-specific arguments " +"have been added under the Parallel processing arguments.") +sys.exit(128) labath wrote: > You should

[Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

brucem created this revision. brucem added reviewers: emaste, clayborg, labath, chaoren. brucem added a subscriber: lldb-commits. This also moves the xcode support files to be near or the same as the ones used for cmake. The source/API/liblldb.xcodes.exports differs from the source/API/liblldb.ex

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

brucem added a comment. This uses some machinery from LLVM's cmake scripts. I'm not sure what happens with this on FreeBSD, NetBSD, etc. http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

labath added a comment. The linux parts are ok. This reduces the size of liblldb by about 13%. Good work. :) http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

krytarowski updated this revision to Diff 33944. krytarowski added a comment. Inverse wrong logic Repository: rL LLVM http://reviews.llvm.org/D12582 Files: include/lldb/Host/HostGetOpt.h include/lldb/Host/common/GetOptInc.h include/lldb/Host/windows/getopt/GetOptInc.h source/Host/CMa

[Lldb-commits] [lldb] r246777 - Mark TestAttachResume as flaky on linux

Author: labath Date: Thu Sep 3 10:44:16 2015 New Revision: 246777 URL: http://llvm.org/viewvc/llvm-project?rev=246777&view=rev Log: Mark TestAttachResume as flaky on linux There is a more race condition regarding process detach, which this test exposes, marking as flaky until it is fixed. Modi

[Lldb-commits] [lldb] r246776 - Fix logging message

Author: labath Date: Thu Sep 3 10:44:14 2015 New Revision: 246776 URL: http://llvm.org/viewvc/llvm-project?rev=246776&view=rev Log: Fix logging message Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL: http://llvm.org/viewvc/llvm-project/lld

[Lldb-commits] [PATCH] D12601: Fix TestLoadUnload.test_load_unload for android API > 21

tberghammer created this revision. tberghammer added a reviewer: ovyalov. tberghammer added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. Fix TestLoadUnload.test_load_unload for android API > 21 * Change Module::MatchesModuleSpec to return true in case the file spe

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala updated this revision to Diff 33951. tfiala added a comment. Added newline to dosep.py error sent via sys.stderr.write() when called directly. http://reviews.llvm.org/D12587 Files: test/CMakeLists.txt test/Makefile test/dosep.py test/dotest.py test/dotest_args.py www/test.ht

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a comment. Also, I should mention this was tested on OS X in addition to Linux. Let me know when you get a chance to run it on Windows, Zachary. > Are there any plans to actually just kill dosep.py at some point? Hmm not seeing my response to this from my phone last night, so at t

Re: [Lldb-commits] [PATCH] D11102: Set the default language to use when evaluating to that of the frame's CU.

spyffe accepted this revision. spyffe added a comment. Looks good to me. Thanks, Dawn. Repository: rL LLVM http://reviews.llvm.org/D11102 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] r246783 - i386 and i686 are equivalent, update the test accordingly.

Author: zturner Date: Thu Sep 3 11:41:31 2015 New Revision: 246783 URL: http://llvm.org/viewvc/llvm-project?rev=246783&view=rev Log: i386 and i686 are equivalent, update the test accordingly. Modified: lldb/trunk/test/functionalities/disassembly/TestDisassembleBreakpoint.py Modified: lldb/

[Lldb-commits] [PATCH] D12602: Separate ClangExpressionVariable from ExpressionVariable

spyffe created this revision. spyffe added a reviewer: jingham. spyffe added a subscriber: lldb-commits. spyffe set the repository for this revision to rL LLVM. This patch separates the generic portion of ClangExpressionVariable, which stores information about a variable that different parts of L

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

tfiala added a subscriber: tfiala. tfiala added a comment. In http://reviews.llvm.org/D12599#239281, @labath wrote: > The linux parts are ok. This reduces the size of liblldb by about 13%. Good > work. :) 13% size decrease sounds nice! Was that with a DebugAsserts build, optimized, or what?

[Lldb-commits] [lldb] r246787 - NetBSD ships with paccept(2), a superset of accept4(2)

Author: sas Date: Thu Sep 3 12:11:31 2015 New Revision: 246787 URL: http://llvm.org/viewvc/llvm-project?rev=246787&view=rev Log: NetBSD ships with paccept(2), a superset of accept4(2) Summary: accept4(2) and paccept(2) are nonstandard extensions. Reviewers: joerg, sas Subscribers: emaste, sas,

Re: [Lldb-commits] [PATCH] D12485: NetBSD ships with paccept(2), a superset of accept4(2)

sas closed this revision. sas added a comment. Committed. [sas@sas-fbro ~/Source/llvm/tools/lldb (arcpatch-D12485)] git svn dcommit Committing to https://llvm.org/svn/llvm-project/lldb/trunk ... M source/Host/common/Socket.cpp Committed r246787 M source/Host/comm

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a reviewer: zturner. tfiala added a comment. http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12585: Add a TypeSystem for Go

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a few cleanups to do mentioned in the inlined comments. Comment at: include/lldb/Core/Module.h:950 @@ -949,1 +949,3 @@ +GoASTContext &GetGoASTContext(

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

About to take a look at this On Thu, Sep 3, 2015 at 10:29 AM Greg Clayton wrote: > clayborg accepted this revision. > clayborg added a comment. > This revision is now accepted and ready to land. > > Looks good. > > > http://reviews.llvm.org/D12587 > > > >

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

zturner added a comment. About to take a look at this http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12601: Fix TestLoadUnload.test_load_unload for android API > 21

ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. LGTM Comment at: source/Core/Module.cpp:1712 @@ -1712,1 +1711,3 @@ +if (!FileSpec::Equal (file_spec, m_file, (bool)file_spec.GetDirectory()) && +!FileSp

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

lgtm On Thu, Sep 3, 2015 at 8:05 AM Kamil Rytarowski wrote: > krytarowski updated this revision to Diff 33944. > krytarowski added a comment. > > Inverse wrong logic > > > Repository: > rL LLVM > > http://reviews.llvm.org/D12582 > > Files: > include/lldb/Host/HostGetOpt.h > include/lldb/Ho

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

zturner added a comment. lgtm Repository: rL LLVM http://reviews.llvm.org/D12582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12584: Fix TestCompletion.py failure on Darwin after r246639

chying added a comment. Based on experiment I had, we need to send empty lines the same times as the number of lines in original commands on Darwin. But on Linux, only one empty line is needed for multiple lines of commands. It seems on Darwin, lldb doesn't automatically execute commands separate

Re: [Lldb-commits] [PATCH] D12589: SystemRuntime/MacOSX no longer need ObjCRuntime header.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D12589 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a comment. In http://reviews.llvm.org/D12587#239410, @zturner wrote: > About to take a look at this Great, thanks. http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

jingham added a comment. That looks great. Here are some comments that are not requirements for getting this in but just for you to consider: If you think you are ever likely to add different ways to specify the name (e.g. if passing a regex might be useful) it might be good to pass the name a

Re: [Lldb-commits] [PATCH] D12584: Fix TestCompletion.py failure on Darwin after r246639

This revision was automatically updated to reflect the committed changes. Closed by commit rL246791: Fix TestCompletion.py failure on Darwin after r246639 (authored by chying). Changed prior to commit: http://reviews.llvm.org/D12584?vs=33898&id=33960#toc Repository: rL LLVM http://reviews.l

[Lldb-commits] [lldb] r246791 - Fix TestCompletion.py failure on Darwin after r246639

Author: chying Date: Thu Sep 3 13:29:27 2015 New Revision: 246791 URL: http://llvm.org/viewvc/llvm-project?rev=246791&view=rev Log: Fix TestCompletion.py failure on Darwin after r246639 Summary: - send empty line for multiple commands to complete Reviewers: tberghammer Subscribers: lldb-commit

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

zturner added inline comments. Comment at: test/CMakeLists.txt:65 @@ -64,3 +64,3 @@ ${LLDB_SOURCE_DIR}/test/dotest.py - "${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}" + "--no-multiprocess;${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}" "Testing LLDB with args: ${LLDB_T

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few changes. I think this might create problems for DWARF in .o files on MacOSX. Are you able to test on MacOSX? We used to store the compile unit index in the upper 32 bits o

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added inline comments. Comment at: test/CMakeLists.txt:65 @@ -64,3 +64,3 @@ ${LLDB_SOURCE_DIR}/test/dotest.py - "${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}" + "--no-multiprocess;${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}" "Testing LLDB with args: ${LLDB_TE

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Did you check who is all calling this? Is it only places that know that an address is code? It seems like we have might have different clients expecting different things out of t

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

Ok, seems fine. No other issues on my side On Thu, Sep 3, 2015 at 11:47 AM Todd Fiala wrote: > tfiala added inline comments. > > > Comment at: test/CMakeLists.txt:65 > @@ -64,3 +64,3 @@ >${LLDB_SOURCE_DIR}/test/dotest.py > - "${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

zturner added a comment. Ok, seems fine. No other issues on my side http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r246794 - Roll dosep.py parallel test runner into dotest.py command line

Author: tfiala Date: Thu Sep 3 13:58:44 2015 New Revision: 246794 URL: http://llvm.org/viewvc/llvm-project?rev=246794&view=rev Log: Roll dosep.py parallel test runner into dotest.py command line See the following for details: http://reviews.llvm.org/D12587 Modified: lldb/trunk/test/CMakeLis

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala closed this revision. tfiala added a comment. Submitted here: $ svn commit Sendingtest/CMakeLists.txt Sendingtest/Makefile Sendingtest/dosep.py Sendingtest/dotest.py Sendingtest/dotest_args.py Sendingwww/test.html Transmitting

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a comment. In http://reviews.llvm.org/D12587#239494, @zturner wrote: > Ok, seems fine. No other issues on my side Great, thanks. I'm going to get this in. http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@li

Re: [Lldb-commits] [PATCH] D12582: Move GetOptInc to the common namespace

krytarowski added a comment. Thank you. When the review will be done, please commit it. Repository: rL LLVM http://reviews.llvm.org/D12582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/l

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

chying added a comment. Sorry, coming late to this thread. This change works ok on linux and darwin systems. But it has some problem on Windows, the main code has to be protected with the following statement on Windows, if __name__ == '__main__': Otherwise it creates subprocesses recursively.

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

zturner added a comment. I didn't see this when I ran ninja check-lldb, but Adrian is seeing the same thing on his machine for some reason. http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

I didn't see this when I ran ninja check-lldb, but Adrian is seeing the same thing on his machine for some reason. On Thu, Sep 3, 2015 at 3:06 PM Ying Chen wrote: > chying added a comment. > > Sorry, coming late to this thread. > This change works ok on linux and darwin systems. > > But it has s

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

I actually am seeing this now, I'm not sure why I didn't see it earlier, the only thing I can think of is that the patch didn't apply successfully even though I thoguht it did. When I stop at this line: if num_threads > 1: pool = multiprocessing.Pool( num_threads,

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

zturner added a comment. I actually am seeing this now, I'm not sure why I didn't see it earlier, the only thing I can think of is that the patch didn't apply successfully even though I thoguht it did. When I stop at this line: if num_threads > 1: pool = multiprocessing.Pool( n

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a comment. In http://reviews.llvm.org/D12587#239625, @chying wrote: > Sorry, coming late to this thread. > This change works ok on linux and darwin systems. Hi @chying, > But it has some problem on Windows, the main code has to be protected with > the following statement on Wind

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a comment. In http://reviews.llvm.org/D12587#239639, @zturner wrote: > I actually am seeing this now, I'm not sure why I didn't see it earlier, > the only thing I can think of is that the patch didn't apply successfully > even though I thoguht it did. > > When I stop at this line:

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

I'm testing a fix for this locally. Hold tight On Thu, Sep 3, 2015 at 3:33 PM Todd Fiala wrote: > tfiala added a comment. > > In http://reviews.llvm.org/D12587#239639, @zturner wrote: > > > I actually am seeing this now, I'm not sure why I didn't see it earlier, > > the only thing I can think

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

zturner added a comment. I'm testing a fix for this locally. Hold tight http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D12612: Fix dotest on Windows after multiprocessing refactor

zturner created this revision. zturner added reviewers: tfiala, amccarth, chying. zturner added a subscriber: lldb-commits. On Windows, when you call pool.map, under the hood python will *again* import whatever the main module is. In this case it's dotest.py. Importing dotest then causes all o

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

zturner added a comment. http://reviews.llvm.org/D12612 http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

http://reviews.llvm.org/D12612 On Thu, Sep 3, 2015 at 3:35 PM Zachary Turner wrote: > zturner added a comment. > > I'm testing a fix for this locally. Hold tight > > > http://reviews.llvm.org/D12587 > > > > ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D12613: Lookup function using full name if one with mangled name is not found.

sivachandra created this revision. sivachandra added reviewers: clayborg, spyffe. sivachandra added a subscriber: lldb-commits. Remove expected failure decorators from tests which now should start passing. http://reviews.llvm.org/D12613 Files: source/Expression/ClangExpressionDeclMap.cpp tes

Re: [Lldb-commits] [PATCH] D12612: Fix dotest on Windows after multiprocessing refactor

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Okay I see, makes sense. Particularly the discrepancy. That code will get much nicer (in dotest.py) when that gets some energy put into cleaning it up. Thanks for tracking it down, Zachary!

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

chying added a comment. Sorry, coming late to this thread. This change works ok on linux and darwin systems. But it has some problem on Windows, the main code has to be protected with the following statement on Windows, if __name__ == '__main__': Otherwise it creates subprocesses recursively.

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

Hi Ying, check the patch I just posted, I think it fixes it. On Thu, Sep 3, 2015 at 3:51 PM Ying Chen wrote: > chying added a comment. > > Sorry, coming late to this thread. > This change works ok on linux and darwin systems. > > But it has some problem on Windows, the main code has to be protec

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

zturner added a comment. Hi Ying, check the patch I just posted, I think it fixes it. http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12613: Lookup function using full name if one with mangled name is not found.

clayborg added a comment. I worry a bit about performance here, but we should find any regressions and address them if we run into any. http://reviews.llvm.org/D12613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

Re: [Lldb-commits] [PATCH] D12613: Lookup function using full name if one with mangled name is not found.

spyffe added a comment. What is up with the name such that we have to look for its demangled version? Can you provide an example where this search would be required? http://reviews.llvm.org/D12613 ___ lldb-commits mailing list lldb-commits@lists.l

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a comment. In http://reviews.llvm.org/D12587#239681, @chying wrote: > Yes, I had a clean run. Thanks for all the details, @chying! It looks like Zachary found the culprit. I'm looking forward to hear if his patch fixes it for you. http://reviews.llvm.org/D12587

Re: [Lldb-commits] [PATCH] D12602: Separate ClangExpressionVariable from ExpressionVariable

spyffe removed rL LLVM as the repository for this revision. spyffe updated this revision to Diff 33986. spyffe added a comment. Removed ClangExpressionVariable from the friend list for ValueObject. http://reviews.llvm.org/D12602 Files: include/lldb/Core/ValueObject.h include/lldb/Expression

Re: [Lldb-commits] [PATCH] D12612: Fix dotest on Windows after multiprocessing refactor

chying accepted this revision. chying added a comment. This patch works for me. Although I thought we could put less code in main() function. Then have if __name__ == "__main__": main() But that will require some more work to refactor the code. Probably that could wait for Todd's clean up.

[Lldb-commits] [lldb] r246816 - Protect dotest.py with an if __name__ == "__main__"

Author: zturner Date: Thu Sep 3 18:03:16 2015 New Revision: 246816 URL: http://llvm.org/viewvc/llvm-project?rev=246816&view=rev Log: Protect dotest.py with an if __name__ == "__main__" Modified: lldb/trunk/test/dotest.py Modified: lldb/trunk/test/dotest.py URL: http://llvm.org/viewvc/llvm-

Re: [Lldb-commits] [PATCH] D12612: Fix dotest on Windows after multiprocessing refactor

tfiala added a comment. In http://reviews.llvm.org/D12612#239698, @chying wrote: > This patch works for me. > Although I thought we could put less code in main() function. > Then have > if __name__ == "__main__": > > main() > > But that will require some more work to refactor the code. Prob

Re: [Lldb-commits] [PATCH] D12612: Fix dotest on Windows after multiprocessing refactor

I tried that at first, but unfortunately in order to do that you have to write a line like global dont_do_dsym_test for every global accessed by main. Like you said, Todd can probably clean that up, for now I just wanted to get something working. On Thu, Sep 3, 2015 at 4:02 PM Ying Chen wrote:

Re: [Lldb-commits] [PATCH] D12613: Lookup function using full name if one with mangled name is not found.

sivachandra added a comment. About performance regression, I am not sure if it really does cause any; For those cases where looking up a function with mangled name actually works, the new lookup should not trigger. For those where it does not work, additional lookup could now make it work. Abo

[Lldb-commits] [lldb] r246820 - Lookup function using full name if one with mangled name is not found.

Author: sivachandra Date: Thu Sep 3 18:27:10 2015 New Revision: 246820 URL: http://llvm.org/viewvc/llvm-project?rev=246820&view=rev Log: Lookup function using full name if one with mangled name is not found. Summary: Remove expected failure decorators from tests which now should start passing.

[Lldb-commits] [PATCH] D12615: Teach utilsOsType about NetBSD

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. NetBSD is a free, fast, secure, and highly portable Unix-like Open Source operating system. Repository: rL LLVM ht

[Lldb-commits] [lldb] r246821 - SystemRuntime/MacOSX no longer need ObjCRuntime header.

Author: brucem Date: Thu Sep 3 18:57:09 2015 New Revision: 246821 URL: http://llvm.org/viewvc/llvm-project?rev=246821&view=rev Log: SystemRuntime/MacOSX no longer need ObjCRuntime header. Summary: The AppleGetQueuesHandler code no longer needs to include a header from the AppleObjCRuntime, so we

Re: [Lldb-commits] [PATCH] D12589: SystemRuntime/MacOSX no longer need ObjCRuntime header.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246821: SystemRuntime/MacOSX no longer need ObjCRuntime header. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12589?vs=33903&id=33992#toc Repository: rL LLVM http://reviews

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

brucem added a comment. tfiala, on Mac OS X with this change, the liblldb.dylib went from 58468408 to 53626572 bytes (release build). http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

[Lldb-commits] [lldb] r246822 - Only export public symbols with the cmake build.

Author: brucem Date: Thu Sep 3 19:00:41 2015 New Revision: 246822 URL: http://llvm.org/viewvc/llvm-project?rev=246822&view=rev Log: Only export public symbols with the cmake build. Summary: This also moves the xcode support files to be near or the same as the ones used for cmake. The source/API

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246822: Only export public symbols with the cmake build. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12599?vs=33942&id=33993#toc Repository: rL LLVM http://reviews.llvm.o

  1   2   >