abidh added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:348
@@ -292,1 +347,3 @@
+}
+}
You are not using the DW_AT_GNU_dwo_id. Is this intentional or an oversight?
http://reviews.llvm.org/D12291
_
Author: slthakur
Date: Tue Aug 25 04:52:59 2015
New Revision: 245927
URL: http://llvm.org/viewvc/llvm-project?rev=245927&view=rev
Log:
Fix build on mips
Setting and getting register values as bytes instead of depending on the 128
bit integer support in register value.
This patch will fix the bui
sagar added a comment.
Hi Hans,
I have committed it to the trunk in revision 245927. You can now merge it to
the release branch.
Thanks,
Sagar
Repository:
rL LLVM
http://reviews.llvm.org/D12275
___
lldb-commits mailing list
lldb-commits@lists
Author: tberghammer
Date: Tue Aug 25 05:27:38 2015
New Revision: 245928
URL: http://llvm.org/viewvc/llvm-project?rev=245928&view=rev
Log:
Fix source manager regression caused by r245905
Modified:
lldb/trunk/source/Symbol/SymbolFile.cpp
Modified: lldb/trunk/source/Symbol/SymbolFile.cpp
URL:
Author: tberghammer
Date: Tue Aug 25 06:46:06 2015
New Revision: 245932
URL: http://llvm.org/viewvc/llvm-project?rev=245932&view=rev
Log:
Handle DW_OP_GNU_addr_index in DWARF expressions
Differential revision: http://reviews.llvm.org/D12290
Modified:
lldb/trunk/include/lldb/Expression/DWARFE
Author: tberghammer
Date: Tue Aug 25 06:45:46 2015
New Revision: 245930
URL: http://llvm.org/viewvc/llvm-project?rev=245930&view=rev
Log:
Fix buffer overflow for fixed_form_sizes
The array is indexed by the value in the DW_FORM filed what can be
bigger then the size of the array. This CL add boun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245930: Fix buffer overflow for fixed_form_sizes (authored
by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12239?vs=32946&id=33060#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: tberghammer
Date: Tue Aug 25 06:45:58 2015
New Revision: 245931
URL: http://llvm.org/viewvc/llvm-project?rev=245931&view=rev
Log:
Add support for DW_FORM_GNU_[addr,str]_index
These are 2 new value currently in experimental status used when split
debug info is enabled.
Differential revisi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245932: Handle DW_OP_GNU_addr_index in DWARF expressions
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12290?vs=32971&id=33061#toc
Repository:
rL LLVM
http://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245931: Add support for DW_FORM_GNU_[addr,str]_index
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12238?vs=32949&id=33062#toc
Repository:
rL LLVM
http://reviews.llvm.
bhushan updated this revision to Diff 33063.
bhushan added a comment.
Addressed review comments.
1. Introduced Target::GetBreakableLoadAddress() instead of
Target::AdjustBreakpointInDelaySlot() so that it should look more generic and
targets can calculate the new breakpoint address based on wha
tberghammer updated this revision to Diff 33073.
tberghammer marked 10 inline comments as done.
tberghammer added a comment.
Fix the minor refactors requested in the review.
I haven't changed the approach to return all DIEs from the dwo file when
indexing the main compile unit because I would li
omjavaid updated this revision to Diff 33075.
omjavaid added a comment.
This updated patches correct problems in arm hardware watchpoint support patch
posted earlier.
This patch has been tested on samsung chromebook (ARM - Linux) and PandaBoard
using basic watchpoint test application.
Also it
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with a few minor comments inline
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:397
@@ +396,3 @@
+
+uint32_t control_valu
hans added a comment.
In http://reviews.llvm.org/D12275#231979, @sagar wrote:
> I have committed it to the trunk in revision 245927. You can now merge it to
> the release branch.
Thanks! Merged in r245947.
Repository:
rL LLVM
http://reviews.llvm.org/D12275
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Unless you really know what you are doing, I don't want anyone playing with
this code just to fix some random test case.
What must remain true: we first try the currently selecte
clayborg accepted this revision.
clayborg added a comment.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D12184
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
I also question why Symbo
In http://reviews.llvm.org/D12291#231523, @tberghammer wrote:
> In the current version of the patch the compile units in the main object file
> hands out only the compile unit DIE with the information what is available in
> the main object fi
tberghammer added a comment.
In http://reviews.llvm.org/D12291#232191, @clayborg wrote:
> I also question why Symbo
>
> In http://reviews.llvm.org/D12291#231523, @tberghammer wrote:
>
> > In the current version of the patch the compile units in the main object
> > file hands out only the compile
tberghammer added a comment.
Sorry, first I manage to submit my comments without finishing them.
In http://reviews.llvm.org/D12291#232191, @clayborg wrote:
> I also question why Symbo
>
> In http://reviews.llvm.org/D12291#231523, @tberghammer wrote:
>
> > In the current version of the patch the
clayborg added a comment.
For our DWARF in .o files, I have SymbolFileDWARFDebugMap which loads the DWARF
from .o files. Each .o file is loaded in a completely unchanged version of
SymbolFileDWARF. Any lldb::user_id_t that are generated use:
lldb::user_id_t
SymbolFileDWARF::MakeUserID (dw_o
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Thanks, that looks good to me too.
Repository:
rL LLVM
http://reviews.llvm.org/D12184
___
lldb-commits mailing list
lldb-commits@lists.llvm.
dawn abandoned this revision.
dawn added a comment.
Thank you both for your explanation and reviews. After further investigation
in light of this, it appears the problem most likely lies in the python API.
That's an area I'm unfamiliar with however. I'll open a bug and submit a patch
to disa
Author: omjavaid
Date: Tue Aug 25 13:22:04 2015
New Revision: 245961
URL: http://llvm.org/viewvc/llvm-project?rev=245961&view=rev
Log:
Adds support for hardware watchpoints on Arm targets.
http://reviews.llvm.org/D9703
This updated patches correct problems in arm hardware watchpoint support patc
tberghammer added a comment.
If I understand you correctly then you are suggesting to create a class like
SymbolFileDWARFDebugMap for handling object files with dwo files. I think that
approach is practically have the same code flow as the current one (one symbol
file which one stores a list of
zturner created this revision.
zturner added reviewers: clayborg, spyffe.
zturner added a subscriber: lldb-commits.
There is a certain class of test failures that arise as a result of errors that
occur during cleanup. For the most part, these don't indicate test failures
and so it's useful to d
omjavaid created this revision.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
This patch fixes a few areas where AArch64 hardware watchpoints were not
emitting errors correctly.
This makes sure any ptrace
dawn created this revision.
dawn added reviewers: ted, clayborg.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
See llvm.org/pr24575
Repository:
rL LLVM
http://reviews.llvm.org/D12329
Files:
test/python_api/disassemble-raw-data/TestDisassemble_V
ted added a comment.
My guess is the target create is failing. This line in the test:
target = self.dbg.CreateTargetWithFileAndTargetTriple ("", "thumbv7")
Seems to be the same as:
target create -a thumbv7 ""
On my Linux box, I get this:
(lldb) target create -a thumbv7 ""
Current
clayborg added a comment.
Let me get the DWARFDIE abstraction in and we can see where we are after I get
this in as we will see more of what is possible to abstract when this is done.
http://reviews.llvm.org/D12291
___
lldb-commits mailing list
lld
zturner updated this revision to Diff 33131.
zturner added a comment.
Upload full diffs with context.
http://reviews.llvm.org/D12327
Files:
test/dotest.py
test/lldbtest.py
test/unittest2/case.py
test/unittest2/result.py
Index: test/unittest2/result.py
==
Author: zturner
Date: Tue Aug 25 17:25:33 2015
New Revision: 245984
URL: http://llvm.org/viewvc/llvm-project?rev=245984&view=rev
Log:
XFAIL TestQuoting on Windows.
A couple of edge cases are broken with regards to quote handling.
Fixing this is tracked by http://llvm.org/pr24557
Modified:
l
Author: zturner
Date: Tue Aug 25 17:25:21 2015
New Revision: 245983
URL: http://llvm.org/viewvc/llvm-project?rev=245983&view=rev
Log:
Fix a bunch of portability issues in test executables.
Added:
lldb/trunk/test/expression_command/expr-in-syscall/main.cpp
- copied, changed from r245961,
Author: enrico
Date: Tue Aug 25 18:55:10 2015
New Revision: 245993
URL: http://llvm.org/viewvc/llvm-project?rev=245993&view=rev
Log:
Rename all functionalities/data-formatter test case with radar bug numbers in
them to more meaningful names
Added:
lldb/trunk/test/functionalities/data-format
dawn added a comment.
> My guess is LLDB on OSX doesn't have a platform that would handle a "thumbv7"
> target, so the target create fails.
It looks OK to me. It does:
(lldb) target create -a thumbv7 ""
Current executable set to '' (thumbv7).
(lldb) target list
Current targets:
* ta
dawn added a comment.
Hi Ted,
Your patch is causing it to get set to the dummy target in the 1st call to
CreateTargetInternal, so in the recursive call, is_dummy_target is true, so we
get the new platform but don't set it. Removing the tests for
"!is_dummy_target &&" in your patch fixes the p
dawn removed rL LLVM as the repository for this revision.
dawn updated this revision to Diff 33172.
dawn added a comment.
I'm submitting this revised patch to show the alternate fix described in my
previous comment. Consider this patch as a proposal; if nothing else I'd like
to understand why t
Author: jmolenda
Date: Tue Aug 25 23:07:30 2015
New Revision: 246004
URL: http://llvm.org/viewvc/llvm-project?rev=246004&view=rev
Log:
In SendContinuePacketAndWaitForResponse there is a special bit of
code that looks for a second stop-reply packet in response to an
interrupt (control-c). This is
Awesome, thanks so much Enrico!
On Tue, Aug 25, 2015 at 4:56 PM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: enrico
> Date: Tue Aug 25 18:55:10 2015
> New Revision: 245993
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245993&view=rev
> Log:
> Rename all funct
Author: bhushan.attarde
Date: Wed Aug 26 01:04:54 2015
New Revision: 246015
URL: http://llvm.org/viewvc/llvm-project?rev=246015&view=rev
Log:
[MIPS] Avoid breakpoint in delay slot
SUMMARY:
This patch implements Target::GetBreakableLoadAddress() method that takes
an address
and ch
40 matches
Mail list logo
