Re: [Lldb-commits] [lldb] ee4b462 - [lldb] Fix a warning

2022-01-04 Thread Kazu Hirata via lldb-commits
Hi Shafik, Let's loop in Saleem here, the author of f1585a4b47cc9c08c9a4c10058597f4b7468c227. Do we need to worry about a case where ReadPointerFromMemory, called at PlatformWindows.cpp:379, returns LLDB_INVALID_ADDRESS without setting status to Fail? I am guessing that could theoretically happe

Re: [Lldb-commits] [lldb] ee4b462 - [lldb] Fix a warning

2021-12-06 Thread Shafik Yaghmour via lldb-commits
I am wondering if you also need to check if token != LLDB_INVALID_ADDRESS > On Dec 4, 2021, at 6:34 PM, Kazu Hirata via lldb-commits > wrote: > > > Author: Kazu Hirata > Date: 2021-12-04T18:34:29-08:00 > New Revision: ee4b462693b1ffeccfe1b8fcf0a0c12896ac6e6a > > URL: > https://github.com/llv