Re: [Lldb-commits] [lldb] 22caa3c - [lldb] Add unit test for ClangASTImporter

2019-12-20 Thread Jordan Rupprecht via lldb-commits
Nice, thanks! On Fri, Dec 20, 2019 at 2:53 AM Raphael “Teemperor” Isemann < teempe...@gmail.com> wrote: > Fixed by https://reviews.llvm.org/D71748. Will land this today. > > On 18. Dec 2019, at 23:03, Raphael “Teemperor” Isemann < > teempe...@gmail.com> wrote: > > I’m actually already investigati

Re: [Lldb-commits] [lldb] 22caa3c - [lldb] Add unit test for ClangASTImporter

2019-12-20 Thread Raphael “Teemperor” Isemann via lldb-commits
Fixed by https://reviews.llvm.org/D71748. Will land this today. > On 18. Dec 2019, at 23:03, Raphael “Teemperor” Isemann > wrote: > > I’m actually already investigating that because I see the same failure when I > moved the ::Initialize and ::Terminate calls to SetUp and TearDown as part of >

Re: [Lldb-commits] [lldb] 22caa3c - [lldb] Add unit test for ClangASTImporter

2019-12-18 Thread Raphael “Teemperor” Isemann via lldb-commits
I’m actually already investigating that because I see the same failure when I moved the ::Initialize and ::Terminate calls to SetUp and TearDown as part of D71630. I’ll reply here when I have a fix, thanks! > On Dec 18, 2019, at 10:54 PM, Jordan Rupprecht wrote: > > We're seeing some odd test

Re: [Lldb-commits] [lldb] 22caa3c - [lldb] Add unit test for ClangASTImporter

2019-12-18 Thread Jordan Rupprecht via lldb-commits
We're seeing some odd test failures internally caused by this patch. For whatever reason (test ordering based on hashing, I guess), we're running the tests in a different order than upstream, and TestClangASTContext crashes when TestClangASTImporter runs first. By default, it seems like TestClangA