Thanks, Zachary also pinged me on IRC. This was fixed in r347821.
> On Nov 28, 2018, at 4:09 PM, Leonard Mosescu via Phabricator
> wrote:
>
> lemo added a comment.
>
> I noticed a small problem, this change breaks "lldb -c ". The
> inline comment explains the root cause.
>
> Thanks
>
>
>
One potentially nice way to test this would be to have all the -O, -o, -S,
-s, -Q, and -q just run "script print(N)" where N is some number that
changes at each line, then FileCheck the output
On Mon, Nov 26, 2018 at 6:38 PM Jim Ingham via Phabricator <
revi...@reviews.llvm.org> wrote:
> jingham
There’s actually been a slow push away from cl::opt. It’s less flexible and
doesn’t support some things that the TableGen approach does. Recently
there’s been a few efforts to port existing tools onto TableGen options
from cl::opt.
I don’t think cl::opt is going away anytime soon so if it works I
