Agreed. I'll implement it tomorrow, thanks!
On Tue, Sep 11, 2018 at 7:24 PM Zachary Turner wrote:
> A visitor would work, but unless we need this frequently it might be
> overkill. If we do need it frequently then it would be very helpful though.
>
> For now since we just have this one use case
A visitor would work, but unless we need this frequently it might be
overkill. If we do need it frequently then it would be very helpful though.
For now since we just have this one use case I think a switch statement on
the tag is the simplest. You can group all same cases together and use the
raw
Yes, you are right, we can just to consider some cases important for us in
the function, but I thought to solve the problem in a more general way.
I think that the key problem is that we lose some type info when we get a
`PDBSymbol`. So we need to dyn_cast the symbol multiple times or to analyse
t
On Tue, Sep 11, 2018 at 4:28 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added inline comments.
>
>
>
> Comment at: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:289
> + return GetClassOrFunctionParent(*lexical_parent);
>
That’s fine
On Tue, Sep 11, 2018 at 7:11 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a comment.
>
> @stella.stamenova @ted Fixed with https://reviews.llvm.org/rL341942,
> thanks again!
> @zturner I'll rewrite `GetClassOrFunctionParent` and will c
Lgtm, thanks!
On Wed, Sep 5, 2018 at 6:43 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov updated this revision to Diff 164027.
> aleksandr.urakov added a comment.
>
> Code cleanup
>
>
> https://reviews.llvm.org/D51162
>
> Files:
> include/lldb/Symbol/Cl
I don’t think I’m really a good person to look at AST stuff. I can look for
general style comments, obvious flaws, and test coverage. but you may be
the best person regarding on the content of the patch. Does that sound ok?
On Fri, Aug 31, 2018 at 7:20 AM Aleksandr Urakov via Phabricator <
revi...@
