Re: [Lldb-commits] [PATCH] D47232: Break dependency from Expression -> Commands

2018-05-24 Thread Jim Ingham via lldb-commits
> On May 23, 2018, at 7:21 PM, Zachary Turner wrote: > > > On Wed, May 23, 2018 at 7:04 PM Jim Ingham via Phabricator > wrote: > jingham added a comment. > > I worry when concerns of layering which seem a little artificial to me would > make us add a shadow class for something that is alre

Re: [Lldb-commits] [PATCH] D47232: Break dependency from Expression -> Commands

2018-05-23 Thread Zachary Turner via lldb-commits
On Wed, May 23, 2018 at 7:04 PM Jim Ingham via Phabricator < revi...@reviews.llvm.org> wrote: > jingham added a comment. > > I worry when concerns of layering which seem a little artificial to me > would make us add a shadow class for something that is already well > expressed as it is. If you pa

Re: [Lldb-commits] [PATCH] D47232: Break dependency from Expression -> Commands

2018-05-23 Thread Jim Ingham via lldb-commits
The expression command had two modes before introducing the REPL. You can do: (lldb) expr -- some C expression or you can do: (lldb) expr Enter expressions, then terminate with an empty line to evaluate: 1: first C expression 2: Second C Expression 3: The second only differs from the fi