Re: [Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

2018-01-23 Thread Tatyana Krasnukha via lldb-commits
7+public+2d921c2f326fd...@reviews.llvm.org; Tatyana > Krasnukha via Phabricator > Cc: tatyana.krasnu...@synopsys.com; clayb...@gmail.com; lldb- > comm...@lists.llvm.org > Subject: Re: [Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite > function > > It seems to me better to remove b

Re: [Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

2018-01-23 Thread Jim Ingham via lldb-commits
It seems to me better to remove breakpoint sites under any memory that you are going to overwrite. The old breakpoints aren't guaranteed to make any sense and, for instance, on x86 could do harm (they could end up in the middle of an instruction in the new TEXT.) If you want to do this regular