Re: [Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

2017-06-01 Thread Pavel Labath via lldb-commits
Woops, my bad. I was hoping that "resume" was to "StepInstruction", which does have an immediate action, but i did not check what it actually does. In this case, we could probably just use "StepOut" for the test case, as it should have the same effect - advance the thread until it reaches the next

Re: [Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

2017-05-31 Thread Jim Ingham via lldb-commits
SBThread::Resume instructs lldb to set the resume state on a thread to "eStateRunning", meaning that means the next time you continue the process, that thread will get a chance to run. It has no effect on the StopReason for the thread (it doesn't even start it running except maybe in the not we

Re: [Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

2017-05-30 Thread Zachary Turner via lldb-commits
DenseSet<> provides a method named find_as which lets you use an arbitrary type as the lookup key. The only requirement is that your DenseMapInfo<> that you've specialized provide two methods for each key type you want to use. So using this approach, even if you have a DenseSet S, you can still w

Re: [Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

2017-05-30 Thread Zachary Turner via lldb-commits
Couple of things: 1) Unless you really really want iteration over this map to be in some deterministic order, better to use unordered_map. And if you do want it to be in some deterministic order, you should provde a comparison function, as the default one is probably not what you want. 2) std::ma