Thanks for vigilance. I added a couple more tests in r299729.
On Thu, Apr 6, 2017 at 4:06 PM, Jim Ingham via Phabricator <
revi...@reviews.llvm.org> wrote:
> jingham added a comment.
>
> I'm sorry, I don't have time actually review the code here for
> correctness... But can you make sure that th
No problem. You can't test on all platforms, so changes like this are bound to
sometimes introduce regressions. If you can remember to watch the bots for
systems you don't run or test on that makes the turnaround smoother.
Otherwise, if it's a MacOS problem the QE folks here are sure to tell
Sorry about that and thanks for rolling it back. I'll take a look tomorrow.
On Tue, Apr 4, 2017 at 5:22 PM, Jim Ingham wrote:
> This patch is causing a testsuite failure in ObjC breakpoint setting:
>
> functionalities/breakpoint/objc/TestObjCBreakpoints.py
>
> You must be grabbing ObjC names and
This patch is causing a testsuite failure in ObjC breakpoint setting:
functionalities/breakpoint/objc/TestObjCBreakpoints.py
You must be grabbing ObjC names and somehow treating them as C++ names.
I reverted the patch till the test gets fixed. If you can't get your hands on
an ObjC binary to t