Re: [Lldb-commits] [PATCH] D30807: Use LLVM's directory enumeration code

2017-03-10 Thread Pavel Labath via lldb-commits
I can see both of them making sense, but I would actually prefer the new behavior you inadvertently introduced. I've looked at the callers and it seems no user sets find_directories to false, so I guess it's fine to change the behavior, if we want to. On 10 March 2017 at 14:08, Zachary Turner wro

Re: [Lldb-commits] [PATCH] D30807: Use LLVM's directory enumeration code

2017-03-10 Thread Zachary Turner via lldb-commits
You're right, I didn't notice that. But since you mention it, surely that had to have been a bug in the original implementation right? That flag isn't intended to be a synonym for "non recursive iteration ", because that's what the Next enumeration value is for. The algorithm would intentionally le