Re: [Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

2016-10-05 Thread Zachary Turner via lldb-commits
It looks like there was a problem with this after all. Are your OSX buildbots failing? I only got notification from Linux buildbots. I'm pretty sure everything passes, but I'm going to test again real quick to confirm. On Wed, Oct 5, 2016 at 10:17 AM Zachary Turner wrote: > This revision was

Re: [Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

2016-10-04 Thread Jim Ingham via lldb-commits
Ah, missed it there. No it is fine to put it in the header. Jim > On Oct 4, 2016, at 2:37 PM, Zachary Turner wrote: > > zturner added inline comments. > > >> jingham wrote in BreakpointIDList.cpp:329-330 >> Did you upload the latest version of your patch, I don't see a comment >> here... >