Re: [Lldb-commits] [PATCH] D25099: Refactor Args a different way

2016-10-03 Thread Zachary Turner via lldb-commits
Thanks, I'll fix it up before submitting On Mon, Oct 3, 2016 at 2:40 PM Jim Ingham wrote: > jingham added a comment. > > You messed up the meaning of one comment (noted inline). Otherwise this > looks fine to me too. > > > > > Args.cpp:97-98 > > + // Argument can be split into multiple disconti

Re: [Lldb-commits] [PATCH] D25099: Refactor Args a different way

2016-10-03 Thread Todd Fiala via lldb-commits
Yep I plan on doing that. -Todd > On Oct 3, 2016, at 10:29 AM, Zachary Turner wrote: > > He lgtm'ed my last patch, so I guess he's ok with the general concept. > Perhaps if someone could just run the test suite for me that would be good > enough. > >> On Mon, Oct 3, 2016 at 10:25 AM Todd Fi

Re: [Lldb-commits] [PATCH] D25099: Refactor Args a different way

2016-10-03 Thread Zachary Turner via lldb-commits
He lgtm'ed my last patch, so I guess he's ok with the general concept. Perhaps if someone could just run the test suite for me that would be good enough. On Mon, Oct 3, 2016 at 10:25 AM Todd Fiala wrote: > tfiala added a comment. > > @zturner , Greg is out this week (and was last Friday as well)