Re: [Lldb-commits] [PATCH] D24890: implement timeout sample support for Linux

2016-09-26 Thread Todd Fiala via lldb-commits
tfiala added a comment. BTW, regarding this part: > On Ubuntu 16.04, the requisite support can be retrieved with: > > sudo apt-get install perf-tools-unstable This was incorrect. The perf tool was actually present even without the perf-tools-unstable on Ubuntu 16.04 x86_64. It is just tha

Re: [Lldb-commits] [PATCH] D24890: implement timeout sample support for Linux

2016-09-26 Thread Todd Fiala via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282436: added Linux support for test timeout sampling (authored by tfiala). Changed prior to commit: https://reviews.llvm.org/D24890?vs=72382&id=72553#toc Repository: rL LLVM https://reviews.llvm.or

Re: [Lldb-commits] [PATCH] D24890: implement timeout sample support for Linux

2016-09-26 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D24890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

Re: [Lldb-commits] [PATCH] D24890: implement timeout sample support for Linux

2016-09-23 Thread Todd Fiala via lldb-commits
tfiala added inline comments. Comment at: packages/Python/lldbsuite/pre_kill_hook/linux.py:68 @@ +67,3 @@ +else: +raise Exception("failed to call 'perf record .., error: ") + Haha woops - that should be: ``` raise Exception("failed to call 'per