This revision was automatically updated to reflect the committed changes.
Closed by commit rL277443: Support for OCaml native debugging (authored by
tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D22132?vs=64473&id=66456#toc
Repository:
rL LLVM
https://reviews.llvm.org/D221
ebtaleb added a comment.
In https://reviews.llvm.org/D22132#502204, @tberghammer wrote:
> Do you want me to commit it in for you?
Sure, if you don't mind. Thank you.
https://reviews.llvm.org/D22132
___
lldb-commits mailing list
lldb-commits@lists
tberghammer added a subscriber: tberghammer.
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
Do you want me to commit it in for you?
https://reviews.llvm.org/D22132
___
lldb-commits mailing
ebtaleb added a comment.
What's left for commiting this revision? I did setup git-svn accordingly, but I
don't have a commit bit.
https://reviews.llvm.org/D22132
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D22132
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
ebtaleb updated the summary for this revision.
ebtaleb removed a reviewer: tberghammer.
ebtaleb updated this revision to Diff 64473.
https://reviews.llvm.org/D22132
Files:
cmake/LLDBDependencies.cmake
include/lldb/Symbol/OCamlASTContext.h
include/lldb/Symbol/TypeSystem.h
source/API/System
ebtaleb added a comment.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4315
@@ +4314,3 @@
+if (die.GetLanguage() ==
lldb::eLanguageTypeOCaml) {
+location.SetLocationListSlide(0);
+
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a few fixes and this will be ready.
Comment at: include/lldb/lldb-forward.h:147
@@ -146,2 +146,3 @@
class ObjectFileJITDelegate;
+class OCamlASTContext
