Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

2016-05-25 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: unittests/Utility/ModuleCacheTest.cpp:74 @@ +73,3 @@ +{ +HostInfo::Initialize(); +ObjectFileELF::Initialize(); ovyalov wrote: > If it's one-off initialization can we use setUpTestCase for these purposes > (for Hos

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

2016-05-25 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270684: Add unit tests for ModuleCache (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20570?vs=58244&id=58400#toc Repository: rL LLVM http://reviews.llvm.org/D20570 Files:

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

2016-05-24 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. Comment at: unittests/Utility/ModuleCacheTest.cpp:74 @@ +73,3 @@ +{ +HostInfo::Initialize(); +ObjectFileELF::Initialize(); If it's one-off initialization can we use setUpTestCase for these purposes (for HostInfo::Initialize

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

2016-05-24 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Nothing obvious that will break on Windows here, so looks good. http://reviews.llvm.org/D20570 ___ lldb-commits mailing list lldb-commits@lists