Re: [Lldb-commits] [PATCH] D17182: Adjust for Python-3.

2016-02-12 Thread Siva Chandra via lldb-commits
sivachandra added inline comments. Comment at: source/API/liblldb.exports:4 @@ -3,1 +3,2 @@ init_lld* +PyInit__lld* labath wrote: > zturner wrote: > > I don't really know what the syntax of this file is, but the symbol is > > called `PyInit__lldb`, not `PyInit__

Re: [Lldb-commits] [PATCH] D17182: Adjust for Python-3.

2016-02-12 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 47835. sivachandra marked an inline comment as done. sivachandra added a comment. Address comments http://reviews.llvm.org/D17182 Files: packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/plugins/builder_linux.py packages/Py

Re: [Lldb-commits] [PATCH] D17182: Adjust for Python-3.

2016-02-12 Thread Pavel Labath via lldb-commits
labath accepted this revision. This revision is now accepted and ready to land. Comment at: scripts/Python/modules/readline/readline.cpp:55 @@ -39,1 +54,3 @@ static char* +#if PY_VERSION_HEX >= 0x0300 +simple_readline(FILE *stdin, FILE *stdout, const char *prompt) ---

Re: [Lldb-commits] [PATCH] D17182: Adjust for Python-3.

2016-02-11 Thread Zachary Turner via lldb-commits
zturner added a comment. Very excited to see more platforms trying to get Python 3 working. Comment at: source/API/liblldb.exports:4 @@ -3,1 +3,2 @@ init_lld* +PyInit__lld* I don't really know what the syntax of this file is, but the symbol is called `PyInit__

Re: [Lldb-commits] [PATCH] D17182: Adjust for Python-3.

2016-02-11 Thread Siva Chandra via lldb-commits
sivachandra added a comment. BTW, I should mention that the testsuite run with Python-2.x is still clean with this change applied. http://reviews.llvm.org/D17182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi