tfiala added a subscriber: tfiala.
tfiala added a comment.
This change looks like it introduced a test failure on OS X:
http://lab.llvm.org:8080/green/job/lldb_build_test/16215/
Per another email on lldb-dev, the error emails were not getting generated
because, while the test failure was logged
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259488: Fix single-stepping onto a breakpoint (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D16767?vs=46528&id=46632#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16767
labath added a comment.
In http://reviews.llvm.org/D16767#341259, @amccarth wrote:
> I was chasing this same bug on Windows before I noticed you were working on
> it. I patched in your latest diff, and the problem still occurs.
That is not surprising. These fixes (r259344, and this one) are i
amccarth added a subscriber: amccarth.
amccarth added a comment.
I was chasing this same bug on Windows before I noticed you were working on it.
I patched in your latest diff, and the problem still occurs. In fact, now I
get two failures:
>
labath updated this revision to Diff 46528.
labath added a comment.
Merged test cases, and updated the FreeBSD version. Please take another look.
http://reviews.llvm.org/D16767
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/consecutive_breakpoints/TestConsecutiveBreakpoints
abhishek.aggarwal added a comment.
source/Plugins/Process/FreeBSD/FreeBSDThread.cpp will not compile for FreeBSD.
In Line 576, bp_id is undefined. Please replace it with bp_site_sp->GetID()
http://reviews.llvm.org/D16767
___
lldb-commits mailing li
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks reasonable but should we merge TestSingleStepOntoBreakpoint.py and
TestConsecutiveBreakpoints.py? I think they have quite a bit of code in common.
http://reviews.llvm.org/D167
