Re: [Lldb-commits] [PATCH] D16766: [RenderScript] Use LLVM DWARF language enum

2016-02-03 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259634: [RenderScript] Use LLVM DWARF language enum (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D16766?vs=46656&id=46755#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D16766: [RenderScript] Use LLVM DWARF language enum

2016-02-02 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Yes, the fix above in ClangASTContext.cpp was what I was looking for! Looks good. Repository: rL LLVM http://reviews.llvm.org/D16766 ___

Re: [Lldb-commits] [PATCH] D16766: [RenderScript] Use LLVM DWARF language enum

2016-02-02 Thread Ewan Crawford via lldb-commits
EwanCrawford updated this revision to Diff 46656. EwanCrawford added a comment. Thanks for taking a look, yes I want to use ClangASTContext. Although RenderScript is mostly just C99 checking for it in a function called `LanguageIsC` does seem off. I've put the comparison directly in ClangASTCont

Re: [Lldb-commits] [PATCH] D16766: [RenderScript] Use LLVM DWARF language enum

2016-02-01 Thread Greg Clayton via lldb-commits
clayborg added a comment. See inlined comments. Comment at: source/Target/Language.cpp:272 @@ -271,2 +271,3 @@ case eLanguageTypeC11: +case eLanguageTypeExtRenderScript: return true; Why is this needed? Seems like this is incorrect.