Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-17 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255882: Add AccessModifierOffset to clang-format style (authored by labath). Changed prior to commit: http://reviews.llvm.org/D15562?vs=42988&id=43106#toc Repository: rL LLVM http://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-16 Thread Todd Fiala via lldb-commits
tfiala added a comment. I think we're good with this then, Pavel. http://reviews.llvm.org/D15562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-16 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham added a comment. We don't indent access modifiers, so if AccessModifierOffset does what it's name suggests, then that's right. Jim http://reviews.llvm.org/D15562 ___ lldb-commits mailing list lldb-commi

Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-16 Thread Jim Ingham via lldb-commits
We don't indent access modifiers, so if AccessModifierOffset does what it's name suggests, then that's right. Jim > On Dec 16, 2015, at 8:09 AM, Todd Fiala wrote: > > tfiala added a reviewer: jingham. > tfiala added a comment. > > Hey Jim, this looks right to me. Agree? > > -Todd > > > ht

Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-16 Thread Todd Fiala via lldb-commits
tfiala added a reviewer: jingham. tfiala added a comment. Hey Jim, this looks right to me. Agree? -Todd http://reviews.llvm.org/D15562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co