Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

On Mon, Dec 14, 2015 at 5:39 AM, Tamas Berghammer wrote: > tberghammer added inline comments. > > > Comment at: packages/Python/lldbsuite/test/lldbtest.py:518 > @@ +517,3 @@ > +if hasattr(func, "categories"): > +cat.extend(func.categories) > +func.cate

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

tberghammer added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:518 @@ +517,3 @@ +if hasattr(func, "categories"): +cat.extend(func.categories) +func.categories = cat labath wrote: > tberghammer wrote: > > tfial

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

This revision was automatically updated to reflect the committed changes. Closed by commit rL255493: Make test categories composable (authored by labath). Changed prior to commit: http://reviews.llvm.org/D15451?vs=42522&id=42704#toc Repository: rL LLVM http://reviews.llvm.org/D15451 Files:

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

labath added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:518 @@ +517,3 @@ +if hasattr(func, "categories"): +cat.extend(func.categories) +func.categories = cat tberghammer wrote: > tfiala wrote: > > This code

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

tberghammer added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:518 @@ +517,3 @@ +if hasattr(func, "categories"): +cat.extend(func.categories) +func.categories = cat tfiala wrote: > This code could potentially

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

tfiala accepted this revision. tfiala added a comment. LGTM. I added a few optional comments on possible improvements, but I think they're orthogonal to what you're doing here. Comment at: packages/Python/lldbsuite/test/lldbtest.py:512 @@ -510,3 +511,3 @@ def add_test_categor

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. LGTM Comment at: packages/Python/lldbsuite/test/lldbtest.py:512 @@ -510,3 +511,3 @@ def add_test_categories(cat): -"""Decorate an item with test categories""" +

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

labath updated this revision to Diff 42522. labath added a comment. I've changed my mind and I'm moving back the getCategoriesForTest function into test_result.py. The function only works when the test is currently executing (because of the magic _testMethodName hack), so it's usability as a gen