This revision was automatically updated to reflect the committed changes.
labath marked 3 inline comments as done.
Closed by commit rL254403: Fix race during process interruption (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D14989?vs=41215&id=41482#toc
Repository:
r
jingham added a comment.
This looks correct, I just had a few more nits...
Comment at: source/Target/Process.cpp:3827-3828
@@ -3840,9 +3826,4 @@
-// First make sure we aren't in the middle of handling an event, or we
might restart. This is pretty weak, since
-//
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
One minor nit, but looks good.
Comment at: source/Target/Process.cpp:4622
@@ +4621,3 @@
+
+if (interrupt_requested) {
+if (StateIsStoppedState
labath updated this revision to Diff 41215.
labath added a comment.
Fix typo
http://reviews.llvm.org/D14989
Files:
include/lldb/Target/Process.h
packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
packages/Python/lldbsuite/test/functionalities/attach_resume/
amccarth added a subscriber: amccarth.
amccarth added a comment.
Nice detective work.
Comment at: include/lldb/Target/Process.h:1372
@@ +1371,3 @@
+/// @param[in] use_run_lock
+/// Whether the release the run lock after the stop.
+///
Did you mea
