Re: [Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

2015-11-12 Thread Dawn Perchik via lldb-commits
dawn added a comment. See inline comment. Comment at: source/Symbol/ClangASTContext.cpp:9191 @@ -9189,2 +9190,3 @@ +continue; searched.insert(it->second); symbol_file->ParseDeclsForContext(CompilerDeclContext(this, it->secon

Re: [Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

2015-11-11 Thread Dawn Perchik via lldb-commits
dawn added a subscriber: dawn. dawn accepted this revision. dawn added a reviewer: dawn. dawn added a comment. Patch is correct - without it we loop through the same decl context again. I've tested it locally - there are no new regressions. http://reviews.llvm.org/D14542 ___

Re: [Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

2015-11-11 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Te test case looks good to me. Thanks for adding it. For the actual code change I don' know enough about this area to say anything so please wait for a feedback from Greg. http://r

Re: [Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

2015-11-11 Thread Eugene Leviant via lldb-commits
evgeny777 updated this revision to Diff 39893. evgeny777 added a comment. Added test case http://reviews.llvm.org/D14542 Files: packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespace.py packages/Python/lldbsuite/test/lang/cpp/namespace/main.cpp source/Symbol/ClangASTContext.cpp

Re: [Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

2015-11-10 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer requested changes to this revision. tberghammer added a reviewer: tberghammer. tberghammer added a comment. This revision now requires changes to proceed. Please create a test case for this scenario so it won't break again http://reviews.l