ravitheja added a comment.
Hello,
I tried making an instance on GCE but it asks for a credit card
information which I unfortunately don’t have. Can you provide me maybe access
through some other way ? btw I checked the logs u sent me and the vdso is being
loaded but the unwinding till m
ovyalov added a comment.
In http://reviews.llvm.org/D14118#277675, @ravitheja wrote:
> Hi,
>
> This link for the traces needs a password, could u maybe provide me the
> login details or upload these somewhere else ? Also could u provide me the
> value of the AuxVectors during this test ?
ravitheja added a comment.
Hi,
This link for the traces needs a password, could u maybe provide me the
login details or upload these somewhere else ? Also could u provide me the
value of the AuxVectors during this test ?
BR,
A Ravi Theja
http://reviews.llvm.org/D14118
_
ovyalov added a comment.
You can get test logs from this link -
https://pantheon.corp.google.com/storage/browser/lldb_test_traces/lldb-x86_64-ubuntu-14.04-cmake/?project=android-devtools-lldb-build
I suspect that there are a few problems here:
1. TestHelloWorld - there is a race within the test
Hi,
I actually checked these two testcases, they are passing at my end,
could u send me the logs and the lldb executables , so that I can check at my
end ? I think I can try to resolve it, in other case I will mark them as XFAILS.
-Original Message-
From: Oleksiy Vyalov [mailto:
ravitheja updated this revision to Diff 38637.
ravitheja added a comment.
Updates for previous comments.
http://reviews.llvm.org/D14118
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
test/functiona
ovyalov added a comment.
Hi,
looks like TestHelloWorld and TestInferiorAssert began to fail after this
change -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/7880
Could you mark these tests as XFAILs for now?
http://reviews.llvm.org/D14118
ovyalov accepted this revision.
ovyalov added a comment.
Looks good - minor comments.
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:513
@@ +512,3 @@
+{
+FileSpec file_spec;
+file_spec.SetFile("[vdso]", false);
---
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I don't know anything about shared library loading on Linux.
http://reviews.llvm.org/D14118
___
lldb-commits mailing list
lldb-commits@lists.llvm.
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with a few minor suggestions inline
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:578-579
@@ +577,4 @@
+}
+
+ret
10 matches
Mail list logo
