clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13537
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Ping. Does this look ok?
On Wed, Oct 7, 2015 at 3:50 PM Zachary Turner wrote:
> zturner added inline comments.
>
>
> Comment at: unittests/ScriptInterpreter/CMakeLists.txt:4
> @@ +3,1 @@
> +endif()
> \ No newline at end of file
>
>
> Missed this one in my updat
zturner added inline comments.
Comment at: unittests/ScriptInterpreter/CMakeLists.txt:4
@@ +3,1 @@
+endif()
\ No newline at end of file
Missed this one in my updated patch, but I fixed it locally. Don't want to
update a 3rd revision just for a newline though.
zturner updated this revision to Diff 36806.
zturner added a comment.
Do you mind giving this a run on MacOSX and verifying it still compiles and
test suite passes?
http://reviews.llvm.org/D13537
Files:
source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
source/Plugins/ScriptInte
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Few minor changes.
Comment at:
source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1183
@@ +1182,3 @@
+llvm::StringRef value_str(str
