zturner accepted this revision.
zturner added a reviewer: zturner.
zturner added a comment.
This revision is now accepted and ready to land.
In the future, u sually the reviewer (you in this case) does this by hitting
Accept in Phabricator. I can do it this time though, no worries
http://revie
enlight added a comment.
Hi Zach,
Can you close this issue please?
http://reviews.llvm.org/D13404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
enlight added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:113
@@ +112,3 @@
+ set (PYTHON_LIBRARY ${PYTHON_LIBRARY} PARENT_SCOPE)
+ set (PYTHON_DLL ${PYTHON_LIBRARY} PYTHON_DLL PARENT_SCOPE)
+ set (PYTHON_INCLUDE_DIRS ${PYTHON_INCLUDE_DIRS} PARENT_SCOPE)
zturner updated this revision to Diff 36544.
zturner added a comment.
Updated from Vadim's comments.
http://reviews.llvm.org/D13404
Files:
cmake/modules/LLDBConfig.cmake
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalone.cmake
===
enlight added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:56
@@ +55,3 @@
+message("LLDB embedded Python on Windows requires specifying a value for
PYTHON_HOME. Python support disabled.")
+set(LLDB_DISABLE_PYTHON 1)
+return()
This will
enlight added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:109
@@ +108,3 @@
+ set (PYTHON_EXECUTABLE
$<$:${PYTHON_DEBUG_EXE}>$<$>:${PYTHON_RELEASE_EXE}>
PARENT_SCOPE)
+ set (PYTHON_LIBRARY
$<$:${PYTHON_DEBUG_LIB}>$<$>:${PYTHON_RELEASE_LIB}>
PARENT_SCOPE)
+ se
On Fri, Oct 2, 2015 at 5:54 PM Zachary Turner wrote:
>
> Note that I'm claiming with this revision that LLDB itself works with
> Python versions other than 2.7.
s/claiming/*not* claiming/
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
