dawn added a subscriber: dawn.
dawn closed this revision.
dawn added a comment.
This was committed in svn r251820.
Repository:
rL LLVM
http://reviews.llvm.org/D13073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Yes, that looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
ribrdb added a comment.
Is this ready to submit?
Comment at: source/Expression/LLVMUserExpression.cpp:43-60
@@ +42,20 @@
+
+LLVMUserExpression::LLVMUserExpression(ExecutionContextScope &exe_scope, const
char *expr, const char *expr_prefix,
+
On Tue, Oct 20, 2015 at 7:40 PM Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> jingham added a comment.
>
> The generic parts of this change look fine to me, with a few inlined style
> comments.
>
> I didn't read the Go specific parts of this in detail, I assume you're
> going
jingham added a comment.
The generic parts of this change look fine to me, with a few inlined style
comments.
I didn't read the Go specific parts of this in detail, I assume you're going to
get those right. I mentioned a couple of style things inline, though I didn't
mark everywhere that they
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
So before getting into the details of the patch, there's a structural bit it
would be nice to fix.
When I was separating out bits of the Expression machinery, I assumed that even
brucem added a subscriber: brucem.
brucem added a comment.
Hopefully some helpful comments that will help keep this code in line with
changes that we're making to other parts of the codebase in bulk ...
Comment at: include/lldb/Symbol/GoASTContext.h:394
@@ +393,3 @@
+}
+
ribrdb added a comment.
I suppose JIT might make more sense if we want to implement more complicated
expressions like looping and calling in to go code.
There's lots of issues to solve before we can call into go code however. In
addition to the stack I'm not sure what to do about the GC. Also I
ribrdb added a comment.
Hmm. I assumed you're using clang to generate llvm IR, is that not the case?
I don't really want to write a whole go compiler.
Right now I'm interpreting the AST using the ValueObject API. This also lets me
reuse the error checking and things implemented in the type system
clayborg added a comment.
I see you moved the JIT code over into ClangUserExpression. I was wondering if
all languages might not want to generate llvm IR and then let the JIT make code
from the llvm IR? This is the reason were originally left the IR in the
UserExpression. IR is very generic and
clayborg added a subscriber: clayborg.
clayborg added a comment.
Even though clang isn't done this way for historical reason, I would like to
see the Go expression parser files (.cpp and .h) over into
"source/Plugins/ExpressionParser/Go". The following files should be moved:
include/lldb/Expr
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
We need to get Sean Callanan as a reviewer on this. Jim is out for a few weeks,
so Sean will need to OK this.
Repository:
rL LLVM
http://reviews.llvm.org/D13073
_
12 matches
Mail list logo
