zturner added a comment.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D12582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
lgtm
On Thu, Sep 3, 2015 at 8:05 AM Kamil Rytarowski wrote:
> krytarowski updated this revision to Diff 33944.
> krytarowski added a comment.
>
> Inverse wrong logic
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D12582
>
> Files:
> include/lldb/Host/HostGetOpt.h
> include/lldb/Ho
krytarowski updated this revision to Diff 33944.
krytarowski added a comment.
Inverse wrong logic
Repository:
rL LLVM
http://reviews.llvm.org/D12582
Files:
include/lldb/Host/HostGetOpt.h
include/lldb/Host/common/GetOptInc.h
include/lldb/Host/windows/getopt/GetOptInc.h
source/Host/CMa
labath added a comment.
Looks good after fixing inverting one condition, but I would like to wait for
an ok from zachary also. Linux builds fine after this patch.
Comment at: source/Host/common/GetOptInc.cpp:3
@@ +2,3 @@
+
+#if !defined(REPLACE_GETOPT) && !defined(REPLACE_GETOP
krytarowski updated this revision to Diff 33941.
krytarowski added a comment.
Apply the latest comments to this patch.
Repository:
rL LLVM
http://reviews.llvm.org/D12582
Files:
include/lldb/Host/HostGetOpt.h
include/lldb/Host/common/GetOptInc.h
include/lldb/Host/windows/getopt/GetOptIn
krytarowski added inline comments.
Comment at: include/lldb/Host/HostGetOpt.h:11
@@ -10,3 +10,1 @@
-#ifndef _MSC_VER
-
labath wrote:
> krytarowski wrote:
> > labath wrote:
> > > How about just putting here
> > > ```
> > > #if !defined(_MSC_VER) && !defined(__Net
labath added inline comments.
Comment at: include/lldb/Host/HostGetOpt.h:11
@@ -10,3 +10,1 @@
-#ifndef _MSC_VER
-
krytarowski wrote:
> labath wrote:
> > How about just putting here
> > ```
> > #if !defined(_MSC_VER) && !defined(__NetBSD__)
> > ```
> I dislike ha
krytarowski added a comment.
I've inlined replies to your comments.
Comment at: include/lldb/Host/HostGetOpt.h:11
@@ -10,3 +10,1 @@
-#ifndef _MSC_VER
-
labath wrote:
> How about just putting here
> ```
> #if !defined(_MSC_VER) && !defined(__NetBSD__)
> ```
I d
labath added a comment.
Thanks for merging the two implementations. However, the way you have
implemented it enables the getopt replacement for all platforms. We need to
have it on only for platforms that don't have a native one.
Comment at: include/lldb/Host/HostGetOpt.h:11
@
krytarowski added a comment.
In case that new commit message was lost, it's here:
commit 4193d823f0fdda0799c632c05836c2ed8f26186c
Author: Kamil Rytarowski
Date: Thu Sep 3 12:10:33 2015 +0200
Move GetOptInc to the common namespace
GetOptInc provides getopt(), getopt_long() and getopt_lo
krytarowski updated this revision to Diff 33922.
krytarowski added a comment.
Reuse the Windows' GetOptInc.
Repository:
rL LLVM
http://reviews.llvm.org/D12582
Files:
include/lldb/Host/HostGetOpt.h
include/lldb/Host/common/GetOptInc.h
include/lldb/Host/windows/getopt/GetOptInc.h
sourc
krytarowski added a comment.
I will reuse the Windows version - it comes from some BSD and it's modified.
At the moment I don't have a platform to test build it. Please verify whether
everything is fine.
Repository:
rL LLVM
http://reviews.llvm.org/D12582
_
labath added subscribers: zturner, labath.
labath added a comment.
Since we already have an implementation of getopt for windows, couldn't you use
that one (or improve/replace it if it is missing some features) for netbsd
also? I don't see why it would be necessary to have two independent
reimp
13 matches
Mail list logo
