Re: [Lldb-commits] [PATCH] D12363: Read module list from mini dump

2016-09-21 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r246302. https://reviews.llvm.org/D12363 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D12363: Read module list from mini dump

2015-08-27 Thread Zachary Turner via lldb-commits
looks good On Thu, Aug 27, 2015 at 4:43 PM Adrian McCarthy wrote: > amccarth updated this revision to Diff 33379. > amccarth added a comment. > > Now uses llvm/Support/ConvertUTF.h instead of WinAPI WideCharToMultiByte. > > > http://reviews.llvm.org/D12363 > > Files: > source/Plugins/Process/W

Re: [Lldb-commits] [PATCH] D12363: Read module list from mini dump

2015-08-27 Thread Adrian McCarthy via lldb-commits
amccarth updated this revision to Diff 33379. amccarth added a comment. Now uses llvm/Support/ConvertUTF.h instead of WinAPI WideCharToMultiByte. http://reviews.llvm.org/D12363 Files: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp source/Plugins/Process/Windows/MiniDump/Proc

Re: [Lldb-commits] [PATCH] D12363: Read module list from mini dump

2015-08-27 Thread Adrian McCarthy via lldb-commits
amccarth marked an inline comment as done. amccarth added a comment. New patch coming up. http://reviews.llvm.org/D12363 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12363: Read module list from mini dump

2015-08-27 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:57-63 @@ +56,9 @@ +const auto length_required = +::WideCharToMultiByte(CP_UTF8, 0, md_string->Buffer, md_string->Length, + nullptr, 0,