sagar closed this revision.
sagar added a comment.
Committed in revision 246745
Repository:
rL LLVM
http://reviews.llvm.org/D12356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
jaydeep accepted this revision.
jaydeep added a comment.
This revision is now accepted and ready to land.
Looks good to me
Repository:
rL LLVM
http://reviews.llvm.org/D12356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D12356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sagar updated this revision to Diff 33668.
sagar marked 4 inline comments as done.
sagar added a comment.
Corrected code indent and initialized wr_val correctly.
Repository:
rL LLVM
http://reviews.llvm.org/D12356
Files:
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp
sourc
sagar marked 7 inline comments as done.
Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3160
@@ +3159,3 @@
+if((*ptr == 0 && bnz) || (*ptr != 0 && !bnz) )
+branch_hit = false;
+break;
T
sagar updated this revision to Diff 33567.
sagar added a comment.
Addressed review commenst
Repository:
rL LLVM
http://reviews.llvm.org/D12356
Files:
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
Index: source
tberghammer added a comment.
I don't know too much about mips so I haven't checked if the emulation is
actually correct but the general concept looks good to me. I added a few
comments inline but they are mostly suggestions what you might want to consider.
Comment at:
source/
sagar updated this revision to Diff 33323.
sagar added a comment.
Addressed review comments
Repository:
rL LLVM
http://reviews.llvm.org/D12356
Files:
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
Index: source
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will defer to MIPS experts here. You might thing about adding tberghammer as
a reviewer.
Repository:
rL LLVM
http://reviews.llvm.org/D12356
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
You added 10 new function to the emulator where the first 8 functions and the
last 2 functions are almost identical. I know that the rest of the MIPS64
instruction emulator is having the same issue but I would like to see
jaydeep requested changes to this revision.
This revision now requires changes to proceed.
Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3117
@@ +3116,3 @@
+else
+target = pc + 4;
+
This should be pc + 8. If branch is not t
11 matches
Mail list logo
