bhushan closed this revision.
bhushan added a comment.
Closed by commit http://reviews.llvm.org/rL246015
Repository:
rL LLVM
http://reviews.llvm.org/D12184
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Thanks, that looks good to me too.
Repository:
rL LLVM
http://reviews.llvm.org/D12184
___
lldb-commits mailing list
lldb-commits@lists.llvm.
clayborg accepted this revision.
clayborg added a comment.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D12184
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bhushan updated this revision to Diff 33063.
bhushan added a comment.
Addressed review comments.
1. Introduced Target::GetBreakableLoadAddress() instead of
Target::AdjustBreakpointInDelaySlot() so that it should look more generic and
targets can calculate the new breakpoint address based on wha
jingham added a subscriber: jingham.
jingham requested changes to this revision.
jingham added a reviewer: jingham.
jingham added a comment.
This revision now requires changes to proceed.
I wish we had a better abstraction for machine-specific behaviors than
ArchSpec, since it seems sad to put th
