This revision was automatically updated to reflect the committed changes.
Closed by commit rL245495: Read exception records from Windows mini dump
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D12126?vs=32476&id=32606#toc
Repository:
rL LLVM
http://reviews.llvm.or
amccarth updated this revision to Diff 32476.
amccarth added a comment.
Forgot to flip logic for the early outs.
http://reviews.llvm.org/D12126
Files:
source/Plugins/Process/Windows/ExceptionRecord.h
source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp
source/Plugins/Process/win-min
zturner added inline comments.
Comment at: source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp:172
@@ -174,1 +171,3 @@
{
+if (m_data_up) return;
+if (m_data_up->m_exception_sp) return;
I know :-/ Not saying I agree or disagree, it's just the LLVM
amccarth updated this revision to Diff 32475.
amccarth marked an inline comment as done.
amccarth added a comment.
Addresses some of Zach's comments.
http://reviews.llvm.org/D12126
Files:
source/Plugins/Process/Windows/ExceptionRecord.h
source/Plugins/Process/win-minidump/ProcessWinMiniDump
amccarth marked 2 inline comments as done.
Comment at: source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp:173
@@ -174,1 +172,3 @@
{
+if (m_data_up && m_data_up->m_exception_sp)
+{
zturner wrote:
> Can you invert this conditional and early-out to k
zturner added a comment.
I would really like to start seeing tests go in at the same time as the
patches. Can any of this functionality be tested yet? i.e. are there commands
that will exercise this code? Also still haven't seen tests go in for the
basic minidump functionality, like a test t
