Re: [Lldb-commits] [PATCH] D12020: Print unexpected successes at the end of dosep.

2015-08-13 Thread Chaoren Lin via lldb-commits
chaoren accepted this revision. chaoren added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

Re: [Lldb-commits] [PATCH] D12020: Print unexpected successes at the end of dosep.

2015-08-13 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: test/dosep.py:500 @@ +499,3 @@ +print "\nUnexpected Successes (%d)" % len(unexpected_successes) +for u in unexpected_successes: +print "UNEXPECTED SUCCESS: LLDB (suite) :: %s (%s)" % (u, system_info) -

Re: [Lldb-commits] [PATCH] D12020: Print unexpected successes at the end of dosep.

2015-08-13 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 32110. http://reviews.llvm.org/D12020 Files: test/dosep.py Index: test/dosep.py === --- test/dosep.py +++ test/dosep.py @@ -121,23 +121,28 @@ def parse_test_results(output): passes = 0

Re: [Lldb-commits] [PATCH] D12020: Print unexpected successes at the end of dosep.

2015-08-13 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: test/dosep.py:266 @@ -259,2 +266,2 @@ timed_out = sum([result[0] for result in test_results], []) passed = sum([result[1] for result in test_results], []) chaoren wrote: > There's a line above this: > ``` > # re

Re: [Lldb-commits] [PATCH] D12020: Print unexpected successes at the end of dosep.

2015-08-13 Thread Chaoren Lin via lldb-commits
chaoren added inline comments. Comment at: test/dosep.py:202 @@ -196,1 +201,3 @@ if status != ePassed] +xpasses = [name for name, status, _, _, unexpected_successes in results if unexpected_successes > 0] + Don't need status here. Nit: cou