Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

2015-08-10 Thread Ilia K via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL244573: Add size field to library load event (MI) (authored by ki.stfu). Changed prior to commit: http://reviews.llvm.org/D11574?vs=31038&id=31772#toc Repository: rL LLVM http://reviews.llvm.org/D11

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

2015-08-10 Thread Ilia K via lldb-commits
ki.stfu added a comment. In http://reviews.llvm.org/D11574#220627, @paulmaybee wrote: > Can you please check in in for me. Thanks. Ok, tomorrow. http://reviews.llvm.org/D11574 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

2015-08-10 Thread Paul Maybee via lldb-commits
paulmaybee added a comment. Can you please check in in for me. Thanks. http://reviews.llvm.org/D11574 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

2015-08-08 Thread Hafiz Abid Qadeer via lldb-commits
abidh added a comment. In http://reviews.llvm.org/D11574#219248, @paulmaybee wrote: > I'm not sure what the misunderstanding is, so I'll rephrase our desire. The > VS debugger decorates code addresses with the name of the shared library from > which the code originated (example above). We wish

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

2015-08-07 Thread Paul Maybee via lldb-commits
paulmaybee added a comment. I'm not sure what the misunderstanding is, so I'll rephrase our desire. The VS debugger decorates code addresses with the name of the shared library from which the code originated (example above). We wish to use the load address and size of the shared library text f

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

2015-08-07 Thread Hafiz Abid Qadeer via lldb-commits
abidh added a comment. I asked this question in the other revision too. Can you give a reason why this field is needed. The following description you gave in this revision does not make much sense to me. I am not opposed to adding this field but would like to know what problem it solves before

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

2015-08-05 Thread Paul Maybee
paulmaybee added a comment. ping Comment at: test/tools/lldb-mi/TestMiLibraryLoaded.py:31 @@ -30,3 +30,3 @@ "=library-loaded,id=\"%s\",target-name=\"%s\",host-name=\"%s\",symbols-loaded=\"1\",symbols-path=\"%s\",loaded_addr=\"-\"" % (path, path, path, symbols_