Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn accepted this commit. dawn added a comment. Breakage with older cmake versions fixed in svn r251073. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

sas added a comment. Adding quotes doesn't work. I think the patch that @dawn linked is good enough even though the issue is still not fixed on older cmake versions. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn added a comment. Please review http://reviews.llvm.org/D13995 for a proposed fix. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

brucem added a comment. +1 to what @labath said. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

labath added a subscriber: labath. labath added a comment. I don't think we should bump the version over a trivial issue like this. cmake 2.8 is still the default on alot of systems. Wouldn't a well placed quote work also? Like, `FOO="${BAR}" codesign --force --end` Or just putting the command i

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

enlight added a comment. It seems like it should be possible to conditionally enable this using CMAKE_VERSION . However that just means anyone who's silly enough to use an older CMake version may run into the

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn added a comment. One resolution would be to check for the cmake version and conditionally enable the new code, but that's beyond my capabilities - anyone know how? If not, can we please revert this commit? Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 __

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

enlight added a subscriber: enlight. enlight added a comment. I believe LLVM requires CMake 2.8.12 or later (at least that was the case when I looked three weeks ago). Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

krytarowski added a subscriber: krytarowski. krytarowski added a comment. cmake_minimum_required(VERSION 2.8) in CMakeLists.txt Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@li

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

brucem added a subscriber: brucem. brucem added a comment. You are correct: ``-E env`` is new after 3.0. (Not in 3.0, but it is in 3.2.) I think the minimum supported cmake is actually older then 3.0 (2.8.something) ... Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn added a subscriber: dawn. dawn raised a concern with this commit. dawn added a comment. First, sorry for my delay in reviewing your patch, but I've been on vacation and now am at the C++ ANSI meeting in Kona for this week. But... This broke the build of cmake on OSX. We get: [...] [2

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn added a subscriber: lldb-commits. Users: sas (Author) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits