Re: [Lldb-commits] [lldb] r367385 - [CompletionRequest] Remove unimplemented members.

2019-07-31 Thread Jim Ingham via lldb-commits
This wasn't a "weird thing". When you have a match with potentially many hits, it would be very handy to say "give me the first 10", then "give me the next 10" so you only do the work to fetch as much as your paginator would show. That would allow us to avoid unnecessary work when somebody g

Re: [Lldb-commits] [lldb] r367385 - [CompletionRequest] Remove unimplemented members.

2019-07-31 Thread Raphael “Teemperor” Isemann via lldb-commits
Thanks! Wasn’t sure back then if I can just remove that weird thing > On Jul 31, 2019, at 5:48 AM, Jonas Devlieghere via lldb-commits > wrote: > > Author: jdevlieghere > Date: Tue Jul 30 20:48:29 2019 > New Revision: 367385 > > URL: http://llvm.org/viewvc/llvm-project?rev=367385&view=rev > Log

[Lldb-commits] [lldb] r367385 - [CompletionRequest] Remove unimplemented members.

2019-07-30 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Jul 30 20:48:29 2019 New Revision: 367385 URL: http://llvm.org/viewvc/llvm-project?rev=367385&view=rev Log: [CompletionRequest] Remove unimplemented members. Completion requests have two fields that are essentially unimplemented: `m_match_start_point` and `m_max_ret