Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

2020-01-31 Thread Adrian Prantl via lldb-commits
> On Jan 31, 2020, at 4:53 PM, Jim Ingham wrote: > > That shouldn't be ASAN specific, that should happen on and > LLDB_CONFIGURATION_DEBUG build. If it only happens on ASAN builds, something > else must be going wrong. > > BTW, those asserts only make sense if you can't re-enter the command

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

2020-01-31 Thread Jim Ingham via lldb-commits
That shouldn't be ASAN specific, that should happen on and LLDB_CONFIGURATION_DEBUG build. If it only happens on ASAN builds, something else must be going wrong. BTW, those asserts only make sense if you can't re-enter the command interpreter while a command is active. In the case of a comman

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

2020-01-31 Thread Vedant Kumar via lldb-commits
Interesting. I'll keep poking at this. > On Jan 31, 2020, at 4:04 PM, Adrian Prantl via lldb-commits > wrote: > > This could be the known bug where a CommandObject is scheduled while the same > CommandObject is already deeper on the command stack. I tried digging up the > bugreport for that,

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

2020-01-31 Thread Adrian Prantl via lldb-commits
This could be the known bug where a CommandObject is scheduled while the same CommandObject is already deeper on the command stack. I tried digging up the bugreport for that, but I couldn't find it. -- adrian > On Jan 31, 2020, at 3:59 PM, Vedant Kumar wrote: > > > >> On Mar 5, 2019, at 5:0

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

2020-01-31 Thread Vedant Kumar via lldb-commits
> On Mar 5, 2019, at 5:07 PM, Adrian Prantl via lldb-commits > wrote: > > Author: adrian > Date: Tue Mar 5 17:07:45 2019 > New Revision: 355466 > > URL: http://llvm.org/viewvc/llvm-project?rev=355466&view=rev > Log: > Replace debug-only assert with a plain old assert. > > Modified: >lld

[Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

2019-03-05 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Tue Mar 5 17:07:45 2019 New Revision: 355466 URL: http://llvm.org/viewvc/llvm-project?rev=355466&view=rev Log: Replace debug-only assert with a plain old assert. Modified: lldb/trunk/source/Interpreter/CommandObject.cpp Modified: lldb/trunk/source/Interpreter/CommandObj