The problem was actually in the native pdb plugin. I forgot to call
ClangASTContext::SetHasExternalStorage with true on the enum decls when i
created it, so it wasn't getting completed. I submitted a fix in r346517.
On Thu, Nov 8, 2018 at 2:00 PM Greg Clayton wrote:
> Another way to think abou
Another way to think about this is if you have a SBValue that represents a
class instances in an IDE, if no one turns it open to see the children, why do
we need to complete the type? We should have to. The type should be able to
complete itself if and when we need to know some information. This
Looks like this test was testing the functionality that you changed. It it
expecting that a type won't be complete until you ask for more info about it
(like asking about a child). Since PDB is not completing the type up front, we
need to change LLDB or make your previous case work even when han
Cool. I see several tests failing (so there might be multiple issues).
Failing Tests (9):
LLDB :: tools/lldb-mi/symbol/symbol-list-lines.test
lldb-Suite ::
functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
lldb-Suite :: functionalities/type_completion/TestTypeCompletion.
Go ahead and revert to green until i get back
On Thu, Nov 8, 2018 at 1:17 PM Zachary Turner wrote:
> +greg.
>
> Greg, is the test wrong here or the patch? If it’s the test let’s just
> fix the test, otherwise we can revert the patch until we figure it out.
>
> It seems related to my change to us
+greg.
Greg, is the test wrong here or the patch? If it’s the test let’s just fix
the test, otherwise we can revert the patch until we figure it out.
It seems related to my change to use the layout type instead of the forward
type.
On Thu, Nov 8, 2018 at 1:03 PM Davide Italiano
wrote:
> On Th
On Thu, Nov 8, 2018 at 12:59 PM Zachary Turner wrote:
>
> I’m ooo for at least 2 hours. Is it a test failure or a compilation failure?
FAIL: test_with_run_command_gmodules (TestTypeCompletion.TypeCompletionTestCase)
Check that types only get completed when necessary.
I’m ooo for at least 2 hours. Is it a test failure or a compilation failure?
On Thu, Nov 8, 2018 at 12:56 PM Davide Italiano
wrote:
> Zach, either this or your previous commit broke MacOS.
> Can you please take a look?
> Feel free to ping me (here or on IRC) if you need any help.
>
> http://green
Zach, either this or your previous commit broke MacOS.
Can you please take a look?
Feel free to ping me (here or on IRC) if you need any help.
http://green.lab.llvm.org/green/job/lldb-cmake/12343/
--
Davide
On Thu, Nov 8, 2018 at 10:52 AM Zachary Turner via lldb-commits
wrote:
>
> Author: zturne
Author: zturner
Date: Thu Nov 8 10:50:31 2018
New Revision: 346430
URL: http://llvm.org/viewvc/llvm-project?rev=346430&view=rev
Log:
Fix bug in PE/COFF plugin and ValueObjectVariable.
There are two bugs here. The first is that MSVC and clang-cl
emit their bss section under the name '.data' inst
10 matches
Mail list logo
