Candidate fix submitted in r344429. Thanks for reporting.
On Fri, Oct 12, 2018 at 3:54 PM Zachary Turner wrote:
> Yea that part is clear, I just wonder what it's trying to parse. It
> sounds like an actual PDB file, because otherwise it shouldn't have made it
> that far in the code. But if it
Yea that part is clear, I just wonder what it's trying to parse. It sounds
like an actual PDB file, because otherwise it shouldn't have made it that
far in the code. But if it's an actual PDB file, it shouldn't be failing.
Anyway, the code definitely has a bug in that it doesn't correctly handle
Adrian suggests that parseFileHeaders is returning an error and that needs to
be cleared?
> On Oct 12, 2018, at 3:27 PM, Jason Molenda wrote:
>
> Ah, mystery solved. The lit test specifies REQUIRES Darwin.
>
>> On Oct 12, 2018, at 3:22 PM, Jason Molenda wrote:
>>
>>
>>
>>> On Oct 12, 2
It's strange though, I wonder how it's even getting to this code path. If
it makes it this far we've already confirmed that whatever the input is,
it's an actual PDB file. So I don't know why it would fail to parse.
On Fri, Oct 12, 2018 at 3:29 PM Zachary Turner wrote:
> I think we just need t
I think we just need to add an llvm::consumeError(EC); on both of those
lines before they return failure. Sorry for missing this.
On Fri, Oct 12, 2018 at 3:27 PM Jason Molenda wrote:
> Ah, mystery solved. The lit test specifies REQUIRES Darwin.
>
> > On Oct 12, 2018, at 3:22 PM, Jason Molenda
Ah, mystery solved. The lit test specifies REQUIRES Darwin.
> On Oct 12, 2018, at 3:22 PM, Jason Molenda wrote:
>
>
>
>> On Oct 12, 2018, at 12:47 PM, Zachary Turner via lldb-commits
>> wrote:
>>
>> Resubmit "Add SymbolFileNativePDB plugin."
>>
>> This was originally reverted due to som
> On Oct 12, 2018, at 12:47 PM, Zachary Turner via lldb-commits
> wrote:
>
> Resubmit "Add SymbolFileNativePDB plugin."
>
> This was originally reverted due to some test failures on
> Linux. Those problems turned out to require several additional
> patches to lld and clang in order to fix, w
Author: zturner
Date: Fri Oct 12 12:47:13 2018
New Revision: 344409
URL: http://llvm.org/viewvc/llvm-project?rev=344409&view=rev
Log:
Resubmit "Add SymbolFileNativePDB plugin."
This was originally reverted due to some test failures on
Linux. Those problems turned out to require several additiona
