Re: [Lldb-commits] [lldb] r339920 - Fix lldb-vscode build on Windows

2018-08-16 Thread Zachary Turner via lldb-commits
(I mean it can't right now, but we could probably make it) On Thu, Aug 16, 2018 at 1:35 PM Zachary Turner wrote: > That's a pretty good idea. clang-tidy could probably catch something like > this. > > On Thu, Aug 16, 2018 at 1:13 PM Greg Clayton via lldb-commits < > lldb-commits@lists.llvm.org>

Re: [Lldb-commits] [lldb] r339920 - Fix lldb-vscode build on Windows

2018-08-16 Thread Zachary Turner via lldb-commits
That's a pretty good idea. clang-tidy could probably catch something like this. On Thu, Aug 16, 2018 at 1:13 PM Greg Clayton via lldb-commits < lldb-commits@lists.llvm.org> wrote: > It would be interesting to have some sort of warning or static analyzer to > avoid platform specific name conflict

Re: [Lldb-commits] [lldb] r339920 - Fix lldb-vscode build on Windows

2018-08-16 Thread Greg Clayton via lldb-commits
It would be interesting to have some sort of warning or static analyzer to avoid platform specific name conflicts like CreateEvent. People always use "id" as a variable name and that can cause problems when a header is included in objective C. Thanks for the windows fixes. > On Aug 16, 2018,

[Lldb-commits] [lldb] r339920 - Fix lldb-vscode build on Windows

2018-08-16 Thread Reid Kleckner via lldb-commits
Author: rnk Date: Thu Aug 16 11:24:59 2018 New Revision: 339920 URL: http://llvm.org/viewvc/llvm-project?rev=339920&view=rev Log: Fix lldb-vscode build on Windows Include PosixAPI.h to get a PATH_MAX definition and replace CreateEvent with CreateEventObject to avoid conflicts with the windows.h d