Re: [Lldb-commits] [lldb] r335432 - [FileSpec] Always normalize

2018-06-25 Thread Jonas Devlieghere via lldb-commits
Thanks. Reverted in r335448. On Mon, Jun 25, 2018 at 9:59 AM Pavel Labath wrote: > I believe the raison d'être of the needsNormalization function was the > normalization process is not exactly cheap (it constructs a vector of > StringRefs and whatnot), and measurements showed that this actually

Re: [Lldb-commits] [lldb] r335432 - [FileSpec] Always normalize

2018-06-25 Thread Pavel Labath via lldb-commits
I believe the raison d'être of the needsNormalization function was the normalization process is not exactly cheap (it constructs a vector of StringRefs and whatnot), and measurements showed that this actually is important for performance of lldb . On Sun, 24

[Lldb-commits] [lldb] r335432 - [FileSpec] Always normalize

2018-06-24 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Sun Jun 24 06:31:44 2018 New Revision: 335432 URL: http://llvm.org/viewvc/llvm-project?rev=335432&view=rev Log: [FileSpec] Always normalize Removing redundant components from the path seems pretty harmless. Rather than checking whether this is necessary and then actuall