Re: [Lldb-commits] [lldb] r328020 - [lldb-dotest] Wrap arguments in single quotes

2018-03-21 Thread Jonas Devlieghere via lldb-commits
You are absolutely right. https://reviews.llvm.org/D44728 On Wed, Mar 21, 2018 at 10:01 AM, Pavel Labath wrote: > Instead of trying to guess how the shell will interpret your command line, > it would be better to just use a primitive which bypasses the shell > altogether. For example you can us

Re: [Lldb-commits] [lldb] r328020 - [lldb-dotest] Wrap arguments in single quotes

2018-03-21 Thread Pavel Labath via lldb-commits
Instead of trying to guess how the shell will interpret your command line, it would be better to just use a primitive which bypasses the shell altogether. For example you can use subprocess.call(), and just forward it the list of arguments verbatim. You'd need to do some special processing on the

[Lldb-commits] [lldb] r328020 - [lldb-dotest] Wrap arguments in single quotes

2018-03-20 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Mar 20 12:18:11 2018 New Revision: 328020 URL: http://llvm.org/viewvc/llvm-project?rev=328020&view=rev Log: [lldb-dotest] Wrap arguments in single quotes If we don't wrap arguments to the wrapper in single quotes, combined arguments, for example for -E, don't reach